Closed Bug 1424380 Opened 2 years ago Closed 2 years ago

Have openUILink() provide the correct triggeringPrincipal

Categories

(Core :: DOM: Security, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: kmckinley, Assigned: jkt)

References

(Blocks 1 open bug)

Details

(Whiteboard: [domsecurity-backlog1])

Attachments

(1 file)

Split out openUILink() and callers into a separate issue from bug 1374741. Ensure that callers to openUILink() provide the correct triggeringPrincipal so that all openUILinkIn callers provide the correct triggeringPrincipal.
Kate, I am not sure if we need this in the end. If not, please feel free to close. In the meantime I'll assign it to you.
Assignee: nobody → kmckinley
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [domsecurity-active]
Assignee: kate+bugzilla → attach-and-request
Status: ASSIGNED → NEW
Priority: P2 → P3
Whiteboard: [domsecurity-active] → [domsecurity-backlog1]
Assignee: attach-and-request → jkt
Attachment #8975443 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8975443 [details]
Bug 1424380 - Require triggering principal passed into openUILink().

https://reviewboard.mozilla.org/r/243728/#review249588

r=me in the sense that this code seems OK, though I wouldn't vouch for this actually being all the remaining cases. I guess we'll find out through sentry if we missed anything else...
Attachment #8975443 - Flags: review?(gijskruitbosch+bugs) → review+
Thanks, try seemed happy so will land :)
Pushed by jkingston@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7938de1c782b
Require triggering principal passed into openUILink(). r=Gijs
https://hg.mozilla.org/mozilla-central/rev/7938de1c782b
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.