1424392 - remove unnecessary nsINSSComponent usage in nsNSSCallbacks

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Dana Keeler (she/her) [:keeler]]

PK11PasswordPromptRunnable::RunOnTargetThread instantiates nsINSSComponent and calls GetPIPNSSBundleString/PIPBundleFormatStringFromName to get some localized strings. Since that runs on the main thread, we can call the helpers in nsNSSCertHelper instead.

Comment 1

[Dana Keeler (she/her) [:keeler]]

Attachment: bug 1424392 - remove unnecessary nsINSSComponent usage in nsNSSCallbacks

PK11PasswordPromptRunnable::RunOnTargetThread instantiates nsINSSComponent and
calls GetPIPNSSBundleString/PIPBundleFormatStringFromName to get some localized
strings. Since that runs on the main thread, we can call the helpers in
nsNSSCertHelper instead.

Review commit: https://reviewboard.mozilla.org/r/206778/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206778/

Comment 2

[Mark Goodwin [:mgoodwin]]

Comment on attachment 8935907 [details]
bug 1424392 - remove unnecessary nsINSSComponent usage in nsNSSCallbacks

https://reviewboard.mozilla.org/r/206778/#review213214

Comment 3

[Dana Keeler (she/her) [:keeler]]

Thanks! Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdee1c19727a
I'm fairly sure the failure is an intermittent (I retriggered it and it succeeded the second time), but it doesn't have an associated bug, so I couldn't star it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8d18d87288c
remove unnecessary nsINSSComponent usage in nsNSSCallbacks r=mgoodwin

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f8d18d87288c