Closed
Bug 1424436
Opened 7 years ago
Closed 7 years ago
Asserts in flex api value calculation could be stronger
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: bradwerth, Assigned: bradwerth)
References
Details
Attachments
(1 file)
Bug 1409083 added a chrome api for calculated flex values. In calculating the size deltas from flex basis size to final size, there is an opportunity for stronger asserts: https://bugzilla.mozilla.org/show_bug.cgi?id=1409083#c108. Strengthen those asserts to check the isUsingFlexGrow value.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Attachment #8935961 -
Flags: review?(dholbert)
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8935961 [details]
Bug 1424436 Part 1: Add more asserts in flex api calculation of mainDeltaSize values.
https://reviewboard.mozilla.org/r/206812/#review213322
r=me! Sorry for not getting to this sooner -- this bugmail slipped past me.
Attachment #8935961 -
Flags: review?(dholbert) → review+
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12c2e518c50d
Part 1: Add more asserts in flex api calculation of mainDeltaSize values. r=dholbert
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•