14245 - [DOGFOOD]Attempting to reference data of NULL pointer (JS3250.DLL) [note: win2k]

Status: VERIFIED DUPLICATE of bug 19165

(Core :: JavaScript Engine, defect, P3)

Description

[adiesen]

Thought I'd mess around with this thing a bit so I downloaded CVS, synced
up, built, executed, and ... CRASH!

Looking in NS_NewScriptWindow (nsJSWindow.cpp line 2602) we see the call ...
JSContext *jscontext = (JSContext *)aContext->GetNativeContext();
There is no check for (jscontext == NULL)
Down the callstack a crash occurs in js_AllocGCThing (jsgc.c line 190) when we
attempt the following assignment ...
rt = cx->runtime;
(cx is the local reference to jscontext!)

Callstack:
js_AllocGCThing(JSContext * 0x00000000, unsigned int 0) line 190 + 3 bytes
js_NewObject(JSContext * 0x00000000, JSClass * 0x0169dff0 struct JSClass
WindowClass, JSObject * 0x00000000, JSObject * 0x00000000) line 1079 + 11 bytes
JS_NewObject(JSContext * 0x00000000, JSClass * 0x0169dff0 struct JSClass
WindowClass, JSObject * 0x00000000, JSObject * 0x00000000) line 1398 + 21 bytes
NS_NewScriptWindow(nsIScriptContext * 0x0214a9e0, nsISupports * 0x020c8eb8,
nsISupports * 0x00000000, void * * 0x020c8ed0) line 2604 + 19 bytes
...

System configuration:
OS: Windows 2000 Pro build 2072
CPU: Pentium2 266Mhz
MEMORY: 128MB

Unable to test on other configurations

Comment 1

[Mike McCabe]

Reassigning to kipp, who cvs blames for the lack of jscontext == null checking,
and also for nsJSContext::GetNativeContext.  (Sorry for the sloppy pass...)

(CC'ing norris, as he has a suspicious line smack in the middle -
http://lxr.mozilla.org/seamonkey/source/dom/src/base/nsJSEnvironment.cpp#266 )

I'm also looking at adding an assert to JS_NewObject.

Comment 2

[vidur (gone)]

Well, the null check shouldn't be required since a nsIScriptContext instance
should *always* have a JSContext associated with it. Aside from the unusual
configuration, I can't tell you why this would happen for you alone (presumably
others aren't seeing it, else I'd have heard more about it).

Anything more you can tell me about how to recreate this. If not, I'm going to
have to mark it WORKSFORME.

Comment 3

[cbegle]

updating qa contact.  prashant, i don't know if this is yours, apologies if i'm
reassigning this incorrectly.

Comment 4

[adiesen]

Probably caused by Win2k. I'll keep an eye on it as I get new Win2k builds.
Perhaps change resolution to LATER and check back when Win2k comes down the
line.
Only additional info I forgot to mention was the build env: VC6.

Comment 5

[leger]

Putting on dogfood radar...I think this is a dup though...but this is affecting
many daily.  I tried to use both install and zip builds for Dec 07...no luck due
to this problem.

Comment 6

[rickg]

Taking off PDT radar.

Comment 7

[leger]

This does not work for me. Nor the person who wrote this bug.  but I foudn the
dup.  And will mark as so.

Comment 8

[leger]

*** This bug has been marked as a duplicate of 19165 ***

Comment 9

[Prashant Desale]

Dup. Verified.