Closed Bug 1424524 Opened 7 years ago Closed 7 years ago

some small nsCSSFrameConstructor improvements

Categories

(Core :: Layout, enhancement)

Product:
Core
Component:
Layout
Type:
enhancement
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)

Details

Attachments

(2 files)

part 1 - Use IsFlexContainerForLegacyBox() to avoid code duplication
1.73 KB, patch
dholbert
: review+
Details | Diff | Splinter Review
part 2 - Use IsFlexOrGridContainer() in a few more places
2.75 KB, patch
dholbert
: review+
Details | Diff | Splinter Review
No description provided.
Comment on attachment 8936070 [details] [diff] [review] part 1 - Use IsFlexContainerForLegacyBox() to avoid code duplication Review of attachment 8936070 [details] [diff] [review]: ----------------------------------------------------------------- r=me. Thanks!
Attachment #8936070 - Flags: review?(dholbert) → review+
Comment on attachment 8936071 [details] [diff] [review] part 2 - Use IsFlexOrGridContainer() in a few more places Review of attachment 8936071 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #8936071 - Flags: review?(dholbert) → review+
Pushed by mpalmgren@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e6d30f982268 part 1 - Use IsFlexContainerForLegacyBox() to avoid code duplication. r=dholbert https://hg.mozilla.org/integration/mozilla-inbound/rev/13fa32dda5f2 part 2 - Use IsFlexOrGridContainer() in a few more places. r=dholbert
https://hg.mozilla.org/mozilla-central/rev/e6d30f982268 https://hg.mozilla.org/mozilla-central/rev/13fa32dda5f2
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: