Closed
Bug 1424524
Opened 7 years ago
Closed 6 years ago
some small nsCSSFrameConstructor improvements
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
Details
Attachments
(2 files)
|
1.73 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
|
2.75 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8936070 -
Flags: review?(dholbert)
|
|
Assignee | |
Comment 2•7 years ago
|
||
Attachment #8936071 -
Flags: review?(dholbert)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8936070 [details] [diff] [review] part 1 - Use IsFlexContainerForLegacyBox() to avoid code duplication Review of attachment 8936070 [details] [diff] [review]: ----------------------------------------------------------------- r=me. Thanks!
Attachment #8936070 -
Flags: review?(dholbert) → review+
|
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8936071 [details] [diff] [review] part 2 - Use IsFlexOrGridContainer() in a few more places Review of attachment 8936071 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #8936071 -
Flags: review?(dholbert) → review+
Pushed by mpalmgren@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e6d30f982268 part 1 - Use IsFlexContainerForLegacyBox() to avoid code duplication. r=dholbert https://hg.mozilla.org/integration/mozilla-inbound/rev/13fa32dda5f2 part 2 - Use IsFlexOrGridContainer() in a few more places. r=dholbert
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e6d30f982268 https://hg.mozilla.org/mozilla-central/rev/13fa32dda5f2
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•