Closed Bug 1424524 Opened 2 years ago Closed 2 years ago

some small nsCSSFrameConstructor improvements

Categories

(Core :: Layout, enhancement, trivial)

enhancement
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: mats, Assigned: mats)

Details

Attachments

(2 files)

No description provided.
Comment on attachment 8936070 [details] [diff] [review]
part 1 - Use IsFlexContainerForLegacyBox() to avoid code duplication

Review of attachment 8936070 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Thanks!
Attachment #8936070 - Flags: review?(dholbert) → review+
Comment on attachment 8936071 [details] [diff] [review]
part 2 - Use IsFlexOrGridContainer() in a few more places

Review of attachment 8936071 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8936071 - Flags: review?(dholbert) → review+
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6d30f982268
part 1 - Use IsFlexContainerForLegacyBox() to avoid code duplication.  r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/13fa32dda5f2
part 2 - Use IsFlexOrGridContainer() in a few more places.  r=dholbert
https://hg.mozilla.org/mozilla-central/rev/e6d30f982268
https://hg.mozilla.org/mozilla-central/rev/13fa32dda5f2
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.