1424644 - Check pending state for 'finish_and_pause' and 'finish_from_pause_pending' in observer tests

Status: RESOLVED FIXED

(Core :: DOM: Animation, enhancement, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

There are two test cases for animation observers, 

1) Calling finish() during pause pending, the test name is finish_from_pause_pending
2) Calling finish() after pause pending finished, the test name is finish_and_pause

When I wrote a patch for bug 1416693, I did not notice it, but Boris notice it to me (bug 1416693 comment 6)!  We should check the pending state respectively to make sure whether pending state has been finished or not.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1424644 - Check pending state to make sure the animation has been paused or not.

'finish_from_pause' supposes that finish() is called after pause pending state
is finished.  Whereas 'finish_from_pause_pending' supposes that finish() is
called during pause pending state.  We should check the state respectively.

Review commit: https://reviewboard.mozilla.org/r/206934/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206934/

Comment 2

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=07b398a7df26f49378b2e777fef532dc6bb287d1

Comment 3

[Brian Birtles (:birtles)]

Comment on attachment 8936176 [details]
Bug 1424644 - Check pending state to make sure the animation has been paused or not.

https://reviewboard.mozilla.org/r/206934/#review212886

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c840afb8a68
Check pending state to make sure the animation has been paused or not. r=birtles

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/9c840afb8a68