Closed Bug 1424671 Opened 7 years ago Closed 6 years ago

stylo: Update the tests of clamping the negative values on background-size and mask-size

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1462829

People

(Reporter: boris, Unassigned)

References

Details

We still skip the tests of clamping the negative values on background-size and mask-size [1], so I think we should update it, at least for |LengthOrPercentageOrAuto::Length| and |LengthOrPercentageOrAuto::Percentage| [2]. Besides, mask-size is not correct because we shouldn't use "ComputedValue" [3]. I guess I miss this property while implementing Bug 1374233.

[1] https://searchfox.org/mozilla-central/rev/cd742d763809089925a38178dd2ba5a9069fa855/layout/style/test/test_transitions_per_property.html#113,220
[2] https://searchfox.org/mozilla-central/rev/cd742d763809089925a38178dd2ba5a9069fa855/servo/components/style/values/computed/background.rs#50-55
[3] https://searchfox.org/mozilla-central/rev/cd742d763809089925a38178dd2ba5a9069fa855/servo/components/style/properties/longhand/svg.mako.rs#130
Priority: -- → P3
Assignee: nobody → boris.chiou
https://github.com/servo/servo/pull/19470 may be blocked by this because we don't have test for these two properties. I have to work this first.
Assignee: boris.chiou → nobody
Flags: needinfo?(emilio)
I did this in bug 1462829.
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(emilio)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.