Closed Bug 1424762 Opened 2 years ago Closed 2 years ago

Remove unnecessary sync message from browser/base/content/test/general/browser_tabfocus.js with non-e10s

Categories

(Firefox :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

browser/base/content/test/general/browser_tabfocus.js fails after bug 1193394

https://treeherder.mozilla.org/#/jobs?repo=try&revision=17fca1f2db86843ce54c307cbf4fefd7f6b3936f&group_state=expanded&selectedJob=151166436
> TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_tabfocus.js | Test timed out -
> TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_tabfocus.js | Found a tab after previous test timed out: data:text/html,%3Chtml%20id%3D%27html2%27%3E%3Cbody%20id%3D%27body2%27%3E%3Cbutton%20id%3D%27button2%27%3ETab%202%3C/button%3E%3C/body%3E%3C/html%3E -
> TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_tabfocus.js | Found a tab after previous test timed out: data:text/html,%3Chtml%20id%3D%27html3%27%3E%3Cbody%20id%3D%27body3%27%3E%3Cbutton%20id%3D%27button3%27%3ETab%203%3C/button%3E%3C/body%3E%3C/html%3E -

it adds content script that sends sync message in focus event, that delays history handling, and makes it impossible to go back just after page load.
but the message is not used on non-e10s.
just stop sending it solves the issue.
the content script is unnecessary on non-e10s.
the parent process doesn't send any message, and also doesn't receive any message.
Attachment #8936360 - Flags: review?(dtownsend)
Attachment #8936360 - Flags: review?(dtownsend) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/b59a2deeab14a096124f14ee99e866fec69fc7aa
Bug 1424762 - Remove unnecessary sync message from browser/base/content/test/general/browser_tabfocus.js with non-e10s. r=Mossop
https://hg.mozilla.org/mozilla-central/rev/b59a2deeab14
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.