Closed Bug 1424768 Opened 2 years ago Closed 2 years ago

telemetry accessible tree update time

Categories

(Core :: Disability Access APIs, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

It'd be useful to collect data about how slow we can be on accessible tree updates. We know it may be a bottleneck, but no good data how often that happens and how bad it is.
Attached patch patchSplinter Review
Assignee: nobody → surkov.alexander
Attachment #8936279 - Flags: review?(jteh)
Attachment #8936279 - Flags: review?(francois)
Comment on attachment 8936279 [details] [diff] [review]
patch

Review of attachment 8936279 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/Histograms.json
@@ +47,5 @@
> +    "record_in_processes": ["main", "content"],
> +    "alert_emails": ["asurkov@mozilla.com"],
> +    "bug_numbers": [1424768],
> +    "expires_in_version": "never",
> +    "description": "Accessible tree updates times (ms)",

nit: It'd be nice to elaborate on this a bit; something like:

"The amount of time taken to update the accessibility tree (ms)"
Attachment #8936279 - Flags: review?(jteh) → review+
Comment on attachment 8936279 [details] [diff] [review]
patch

Review of attachment 8936279 [details] [diff] [review]:
-----------------------------------------------------------------

We now have a new process for all new data collection requests: https://wiki.mozilla.org/Firefox/Data_Collection#Step_1:_Submit_Request

Essentially, all you need to do is to download the request form from Github, answer the questions, and then attach it as a textfile on bugzilla and r? me on it.

I will take care of Step 2 in the process once you have attached the form.

::: toolkit/components/telemetry/Histograms.json
@@ +47,5 @@
> +    "record_in_processes": ["main", "content"],
> +    "alert_emails": ["asurkov@mozilla.com"],
> +    "bug_numbers": [1424768],
> +    "expires_in_version": "never",
> +    "description": "Accessible tree updates times (ms)",

I like James' suggestion too.
Attachment #8936279 - Flags: review?(francois) → review-
(In reply to François Marier [:francois] from comment #4)

> Essentially, all you need to do is to download the request form from Github,
> answer the questions, and then attach it as a textfile on bugzilla and r? me
> on it.

ok, np, but that brings me back to 90s/00s with exception I don't have to print it, sign it, scan and send back by post mail :) I wonder if that questionnaire can be integrated into bugzilla similar to what we have for approval requests.

> I will take care of Step 2 in the process once you have attached the form.
> 
> ::: toolkit/components/telemetry/Histograms.json
> @@ +47,5 @@
> > +    "record_in_processes": ["main", "content"],
> > +    "alert_emails": ["asurkov@mozilla.com"],
> > +    "bug_numbers": [1424768],
> > +    "expires_in_version": "never",
> > +    "description": "Accessible tree updates times (ms)",
> 
> I like James' suggestion too.

will do
Attached file request.md
Attachment #8936887 - Flags: review?(francois)
Comment on attachment 8936887 [details]
request.md

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, in Histograms.json

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Yes, Alexander Surkov <asurkov@mozilla.com>.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 1

5) Is the data collection request for default-on or default-off?

Default-on

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No)

No, permanent.
Attachment #8936887 - Flags: review?(francois) → review+
https://hg.mozilla.org/mozilla-central/rev/e7d81ccd3157
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.