Closed
Bug 1424879
Opened 7 years ago
Closed 7 years ago
Enable ESLint rule mozilla/use-services for xpcom
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(2 files)
As we've been doing elsewhere, we should turn on mozilla/use-services for xpcom/ so that we're consistent across the tree.
|
||
Comment 1•7 years ago
|
||
\o/
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8936406 [details]
Bug 1424879 - Move handling of Cc/Ci/etc to head_xpcom.js for XPCOM's unit tests.
https://reviewboard.mozilla.org/r/207122/#review212954
Attachment #8936406 -
Flags: review?(nfroyd) → review+
|
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8936407 [details]
Bug 1424879 - Enable mozilla/use-services for xpcom/.
https://reviewboard.mozilla.org/r/207124/#review212956
Thank you for separating out the other part of this into a separate commit!
Attachment #8936407 -
Flags: review?(nfroyd) → review+
|
Assignee | |
Comment 6•7 years ago
|
||
Thanks for the quick review (and at all-hands!).
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33be9825f192
Move handling of Cc/Ci/etc to head_xpcom.js for XPCOM's unit tests. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/fba9ddd36edd
Enable mozilla/use-services for xpcom/. r=froydnj
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/33be9825f192
https://hg.mozilla.org/mozilla-central/rev/fba9ddd36edd
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•