1424944 - Crash in mozilla::dom::FetchDriverObserver::Release

Status: RESOLVED WORKSFORME

(Core :: Audio/Video: MediaStreamGraph, defect, P2)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-f5a76ef4-2371-403d-b9f2-8a7df0171207.
=============================================================

Seen while looking at nightly crash stats - crashes started in 59 using 20171206221407. 23 crashes/19 installs in 7 days: http://bit.ly/2yiYIVS

Possible regression range based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b4cef8d1dff06a1ec2b9bb17211c0c3c7f5b76fa&tochange=99a3b09ac1898eb1db05430e2876d6643ba0d4a8

Top 10 frames of crashing thread:

0 xul.dll mozilla::dom::FetchDriverObserver::Release dom/fetch/FetchDriver.h:48
1 xul.dll mozilla::AudioChunk::~AudioChunk 
2 xul.dll nsTArray_Impl<mozilla::AudioChunk, nsTArrayInfallibleAllocator>::RemoveElementsAt xpcom/ds/nsTArray.h:2047
3 xul.dll mozilla::MediaSegmentBase<mozilla::AudioSegment, mozilla::AudioChunk>::RemoveLeading dom/media/MediaSegment.h:515
4 xul.dll mozilla::MediaSegmentBase<mozilla::AudioSegment, mozilla::AudioChunk>::ForgetUpTo dom/media/MediaSegment.h:281
5 xul.dll mozilla::StreamTracks::ForgetUpTo dom/media/StreamTracks.cpp:108
6 xul.dll mozilla::MediaStreamGraphImpl::UpdateCurrentTimeForStreams dom/media/MediaStreamGraph.cpp:353
7 xul.dll mozilla::MediaStreamGraphImpl::OneIteration dom/media/MediaStreamGraph.cpp:1496
8 xul.dll mozilla::AudioCallbackDriver::DataCallback dom/media/GraphDriver.cpp:979
9 xul.dll passthrough_resampler<float>::fill media/libcubeb/src/cubeb_resampler.cpp:76

=============================================================

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

FWIW, the FetchDriverObserver bit there looks like bad stack translation.  AFAICT this media code does not directly use fetch API.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Paul - is the recent spike (ForgetUpTo(), etc) due to your backed-out landing?

Comment 3

[Paul Adenot (:padenot)]

Yes. Relanding today with the fix.

Comment 4

[Andrew Overholt [:overholt]]

Should this be closed now?

Comment 5

[Andrew McCreight [:mccr8]]

I don't see any crashes on recent builds, so I'm closing per comment 3.

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Fixed by backout of original landing of Bug 1397793