[e10s] fix regression at Bug 1423810

RESOLVED FIXED in Firefox 59

Status

()

enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: stransky, Assigned: stransky)

Tracking

(Blocks 1 bug)

Trunk
mozilla59
x86_64
Linux
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

a year ago
+++ This bug was initially created as a clone of Bug #1423810 +++

We need to provide better fix for Bug 1423810 and enable titlebar rendering in CSD mode.
(Assignee)

Comment 1

a year ago
It's reproducible with e10s enabled only.
(Assignee)

Updated

a year ago
Summary: fix regression at Bug 1423810 and enable titlebar rendering in CSD mode → [e10s] fix regression at Bug 1423810 and enable titlebar rendering in CSD mode
(Assignee)

Comment 2

a year ago
Looks related to Bug 1196494 - property_notify_event_cb() is not called for mShell when it has child mContainer window.
(Assignee)

Comment 3

a year ago
Posted patch patchSplinter Review
WIP but functional patch, storing here for further work.
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Summary: [e10s] fix regression at Bug 1423810 and enable titlebar rendering in CSD mode → [e10s] fix regression at Bug 1423810

Comment 5

a year ago
mozreview-review
Comment on attachment 8937943 [details]
Bug 1424974 - Honor mShell as top-level window,

https://reviewboard.mozilla.org/r/208642/#review214794

::: widget/gtk/nsWindow.cpp:3897
(Diff revision 1)
>          break;
>      }
>  
>      // label the drawing window with this object so we can find our way home
>      g_object_set_data(G_OBJECT(mGdkWindow), "nsWindow", this);
> +    if (drawToContainer) {

Please add brief description why do you need to add nsWindow reference to the mShell.
Attachment #8937943 - Flags: review?(jhorak) → review+
Comment hidden (mozreview-request)

Comment 7

a year ago
Pushed by stransky@redhat.com:
https://hg.mozilla.org/integration/autoland/rev/872897434908
Honor mShell as top-level window, r=jhorak

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/872897434908
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
(Assignee)

Updated

a year ago
See Also: → 1441665
You need to log in before you can comment on or make changes to this bug.