1425003 - GeckoViewNavigation.jsm references undefined URIFIxup

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Mark Banner (:standard8)]

GeckoViewNavigation.jsm is currently referencing `URIFixup.createExposableURI(locationURI);` however URIFixup is not defined in the file.

It looks like a bad cut/paste when this file was created.

This was picked up when experimenting with turning on ESLint's no-undef rule in mobile/android.

The fix is quite simple, though I think we should swap to Services.urifixup as the rest of mozilla-central code has.

I'll get a patch up in a bit.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1425003 - Fix GeckoViewNavigation.jsm referencing undefined URIFIxup - switch to Services.uriFixup.

Review commit: https://reviewboard.mozilla.org/r/207356/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/207356/

Comment 2

[Mark Banner (:standard8)]

Note: I've not tested this, but ESLint is happy with the fix...

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8936596 [details]
Bug 1425003 - Fix GeckoViewNavigation.jsm referencing undefined URIFIxup - switch to Services.uriFixup.

https://reviewboard.mozilla.org/r/207356/#review213900

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67c2ae51ba58
Fix GeckoViewNavigation.jsm referencing undefined URIFIxup - switch to Services.uriFixup. r=snorp

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/67c2ae51ba58