Closed Bug 1425003 Opened 2 years ago Closed 2 years ago

GeckoViewNavigation.jsm references undefined URIFIxup

Categories

(GeckoView :: General, defect)

defect
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

GeckoViewNavigation.jsm is currently referencing `URIFixup.createExposableURI(locationURI);` however URIFixup is not defined in the file.

It looks like a bad cut/paste when this file was created.

This was picked up when experimenting with turning on ESLint's no-undef rule in mobile/android.

The fix is quite simple, though I think we should swap to Services.urifixup as the rest of mozilla-central code has.

I'll get a patch up in a bit.
Note: I've not tested this, but ESLint is happy with the fix...
Comment on attachment 8936596 [details]
Bug 1425003 - Fix GeckoViewNavigation.jsm referencing undefined URIFIxup - switch to Services.uriFixup.

https://reviewboard.mozilla.org/r/207356/#review213900
Attachment #8936596 - Flags: review?(snorp) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/67c2ae51ba58
Fix GeckoViewNavigation.jsm referencing undefined URIFIxup - switch to Services.uriFixup. r=snorp
https://hg.mozilla.org/mozilla-central/rev/67c2ae51ba58
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 59 → mozilla59
You need to log in before you can comment on or make changes to this bug.