Closed
Bug 1425032
Opened 8 years ago
Closed 8 years ago
reimplement PKCS#11 logout connection resetting using new "cancel all connections" event in necko
Categories
(Core :: Security: PSM, enhancement, P1)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: keeler, Assigned: keeler)
References
(Depends on 1 open bug)
Details
(Whiteboard: [psm-assigned])
Attachments
(1 file)
Bug 1411316 added the event "net:cancel-all-connections", which as I understand it does what it says on the tin. Currently PSM tracks all sockets it creates just in case the user does a PKCS#11 logout (which very few users will ever do). We can get rid of this tracking if we reimplement this functionality on top of the new notification.
![]() |
Assignee | |
Updated•8 years ago
|
Whiteboard: [psm-assigned]
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8936842 [details]
bug 1425032 - use new "cancel all connections" notification for PKCS#11 logout
https://reviewboard.mozilla.org/r/207540/#review213722
::: security/manager/ssl/tests/unit/test_logoutAndTeardown.js:136
(Diff revision 1)
> + observer.stop();
> + });
> + }
> - }
> +}
> +
> +function startServer(cert) {
I might prefer getStartedServer or something that communicates that it returns the server - not a strong opinion though.
Attachment #8936842 -
Flags: review?(mgoodwin) → review+
![]() |
Assignee | |
Comment 3•8 years ago
|
||
mozreview-review-reply |
Comment on attachment 8936842 [details]
bug 1425032 - use new "cancel all connections" notification for PKCS#11 logout
https://reviewboard.mozilla.org/r/207540/#review213722
Thanks!
> I might prefer getStartedServer or something that communicates that it returns the server - not a strong opinion though.
Ok - sounds good.
Comment hidden (mozreview-request) |
![]() |
Assignee | |
Comment 5•8 years ago
|
||
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/746eeb7be002
use new "cancel all connections" notification for PKCS#11 logout r=mgoodwin
Comment 7•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•