Closed
Bug 1425035
Opened 8 years ago
Closed 8 years ago
move --enable-ui-locale to moz.configure; r=build-peer
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox59 fixed)
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
4.72 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
We need MOZ_UI_LOCALE even when building the JS shell so
config/config.mk variable assignments don't run into issues. But it
doesn't make any sense to configure a UI locale for the JS shell. So
make --enable-ui-locale a normal `option`, but give it a `default`,
which is the value shell-only builds will always see.
|
Assignee | |
Comment 1•8 years ago
|
||
My understanding is that this works out OK for JS shell-only builds.
|
|
||
Updated•8 years ago
|
Attachment #8936616 -
Flags: review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6a122e9df80a
move --enable-ui-locale to moz.configure; r=gps
|
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•