1425047 - Enable ESLint rule no-undef for mobile/android/chrome

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement, P5)

Description

[Mark Banner (:standard8)]

Currently the mobile/android/chrome directory reports a lot of no-undef issues.

I think a lot of these are the fact that ESLint doesn't know the actual globals that are available.

It might be that we need something equivalent to the browser-window environment (that we use for browser/base/content), that works out the mobile globlals.

Comment 1

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 2

[Mark Banner (:standard8)]

With the various removals that have gone on and mainly just geckoview left, there's no much to do here to enable the no-undef and no-unused-vars rules.

Additionally, getting the other rules passing that we didn't have passing before is also easy to do.

Hence, I've just done a few patches to get this tidied up. The only bit of remaining enabling would be bug 1424996, but that didn't seem worth it as bug 1583370 will likely make that bit go away.

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1425047 - Enable ESLint rules no-undef and no-unused-vars for mobile/android/chrome/geckoview. r?esawin

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1425047 - Enable already passing rules for mobile/android. r?esawin

Depends on D60824

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1425047 - Enable ESLint rule object-shorthand for mobile/android. r?esawin

Depends on D60825

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1425047 - Enable rest of ESLint rules for mobile/android. r?esawin

This enables consistent-return, no-empty and no-redeclare.

Depends on D60826

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfe93fc476bd
Enable ESLint rules no-undef and no-unused-vars for mobile/android/chrome/geckoview. r=esawin
https://hg.mozilla.org/integration/autoland/rev/cba96b50b796
Enable already passing rules for mobile/android. r=esawin
https://hg.mozilla.org/integration/autoland/rev/f9f175845e62
Enable ESLint rule object-shorthand for mobile/android. r=esawin
https://hg.mozilla.org/integration/autoland/rev/bd96768e10b9
Enable rest of ESLint rules for mobile/android. r=esawin

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/dfe93fc476bd
https://hg.mozilla.org/mozilla-central/rev/cba96b50b796
https://hg.mozilla.org/mozilla-central/rev/f9f175845e62
https://hg.mozilla.org/mozilla-central/rev/bd96768e10b9