1425048 - Enable ESLint rule no-undef for mobile/android/components/extensions/

Status: RESOLVED FIXED

(GeckoView :: Extensions, enhancement, P5)

Description

[Mark Banner (:standard8)]

Currently the mobile/android/components/extensions/ directory reports a lot of no-undef issues.

Most of this will be determining which files are "importing" globals from other files.

Comment 1

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 2

[Mark Banner (:standard8)]

Bug 1583370 is likely going to remove this code.

Comment 3

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.

Comment 4

[Mark Banner (:standard8)]

This bug is still valid for GeckoView: https://searchfox.org/mozilla-central/rev/55d5c4b9dffe5e59eb6b019c1a930ec9ada47e10/mobile/android/.eslintrc.js#10-18

Bug 1583370 didn't remove the code.

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1425048 - Enable ESLint rules no-unused-vars/no-undef for mobile/android/components/extensions/. r?m_kato!,robwu!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3b346e7cdd0
Enable ESLint rules no-unused-vars/no-undef for mobile/android/components/extensions/. r=geckoview-reviewers,extension-reviewers,robwu,owlish

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d3b346e7cdd0