Closed Bug 1425180 Opened 6 years ago Closed 6 years ago

YouTube fullscreen transition is bad

Categories

(Core :: Graphics: WebRender, defect, P2)

Product:
Core
Component:
Graphics: WebRender
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 --- disabled

People

(Reporter: jrmuizel, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

See https://www.reddit.com/r/firefox/comments/7jlqyi/webrender_on_windows_performance_feedback/dr7ggjp/

"Youtube has a transition effect when going full screen; It fades to black, then when the screen is completely black, it fades back in, revealing the full screen player. With webrender enabled, it hangs for a bit when the screen has gone black, making the transition a lot less smooth."
Assignee: nobody → a.beingessner
Some results of investigation: it appears that we aren't properly hooking up the MozAfterPaint event that the fullscreen transition is waiting for. The only reason fullscreen transition works at all is because some merciful soul anticipated shoddy event handling and set up a timeout that forces the fade to black animation to make progress without us doing anything.
Kats correctly identified that this is the result of not implementing GetLastTransactionId. Implementing it fixes the issue.

There are currently other issues with implementing GetLastTransactionId, so this bug is now blocked on Bug 1437036.
Depends on: 1437036
unassigning as this "should" be trivially solved by the above bug.
Assignee: a.beingessner → nobody
Bug 1437036 has landed, so this should be fixed in the next nightly.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.