142523 - data: can't open a xul-application through channel

Status: VERIFIED DUPLICATE of bug 138052

(Core :: Networking, defect)

Description

[Evgeny Sologubov]

Here is simple xul text:
<?xml version='1.0'?>
<?xml-stylesheet href='chrome://global/skin/' type='text/css'?>
<!DOCTYPE window>
<window xmlns='http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul'>
</window>

There is no problem to view it via mfcembed (or even mozilla.exe) in case this text is content of a file.
But when I tried to view it like that:

data:application/vnd.mozilla.xul+xml,<?xml version='1.0'?><?xml-stylesheet href='chrome://global/skin/' type='text/css'?><!DOCTYPE window><window xmlns='http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul'></window>

The "Unknown C++ exception" occurs.

Comment 1

[Evgeny Sologubov]

To get reported bug I just modified mfcembed's CBrowserView::OnFileOpen so it always subsitutes the URL I wrote above.

I also tried to do that using nsDocShell::LoadStream (I make my own nsIInputStream implementer). Result was the same.

Comment 2

[Evgeny Sologubov]

One more comment :)

When I tried to use "data:text/xml" instead of "data:application/vnd.mozilla.xul+xml" there wasn't any "unknown c++ exceptions".
But I need to work exactly with "applications" not the "texts" :(((

P.S. Sorry for my English :(

Comment 3

[timeless]

what build id, and branch or trunk? -- this is important info which you should not omit when filing bugs about the browser crashing.

i think the data protocol handler was recently modified.

Comment 4

[Evgeny Sologubov]

It was 

Comment 5

[Evgeny Sologubov]

Sorry. It's my first Bugzilla request :(

Comment 6

[Evgeny Sologubov]

Reported bug can be fixed by (for example) following changes in nsDataProtocol::ParseData...

    char *dataBuffer = nsnull;
    PRBool cleanup = PR_FALSE;
-    if ( !mContentType.Find("text") && !lBase64) {
+    if ( (mContentType.Find("text") || mContentType.Find("application")) && !lBase64) {
        // it's text, don't compress spaces
        dataBuffer = comma+1;
    } else {
        // it's ascii encoded binary, don't let any spaces in
        nsCAutoString dataBuf(comma+1);

I've virified it on mozilla1.0.rc1

Comment 7

[Evgeny Sologubov]

Marking as INVALID.
See http://bugzilla.mozilla.org/show_bug.cgi?id=138052

Comment 8

[Evgeny Sologubov]

Bug #138052 was fixed 2002-05-04, but changed files still is not included to an official 'Source Code Tarball'.
At least it not appeared in http://ftp.mozilla.org/pub/mozilla/releases/mozilla1.0.1/src/mozilla-source-1.0.1.tar.bz2

Comment 9

[benc]

neeti: any ideas on how to follow up about this question?

Comment 10

[neeti]

reporter: I can see the change from bug 138052 in the mozilla trunk builds.

Comment 11

[Boris Zbarsky [:bzbarsky]]

The fix for bug 138052 was not landed on the branch and will not be landing on
it (since it is not a crash fix, security fix, or fix for a commonly encountered
problem).  Re-resolving; this is fixed on trunk and in 1.x releases for x > 0,
but is not and will not be fixed in 1.0.x releases.

*** This bug has been marked as a duplicate of 138052 ***

Comment 12

[benc]

VERIFIED, looks like same problem from discussion