1425294 - Use a hardcoded background color for mozscreenshots so the APNG will not have transparency

Status: RESOLVED FIXED

(Testing :: mozscreenshots, enhancement)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Bug 1419840 removed the parts of the screenshot that aren't included by the selectors, but the APNG that is shown on the mozscreenshots comparison tool is confusing because it will show transparent parts and then the diff frame will not show that same part as transparent.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1425294 - Use a hardcoded background color for mozscreenshots so the APNG will not have transparency.

Review commit: https://reviewboard.mozilla.org/r/207622/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/207622/

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8936904 [details]
Bug 1425294 - Use a hardcoded background color for mozscreenshots so the APNG will not have transparency.

https://reviewboard.mozilla.org/r/207622/#review213516

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/950963c8a8e1
Use a hardcoded background color for mozscreenshots so the APNG will not have transparency. r=MattN

Comment 4

[Eliza Balazs [:ebalazs_]]

Backed out changeset 950963c8a8e1 (bug 1425294) for failing ss in browser/tools/mozscreenshots/browser_screenshots_cropping.js

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=950963c8a8e193b0c52f72c5563f38f6b6f0056e&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=success&filter-searchStr=cf9dd78470facc9cb169c7da4316c1bd9c3c7121&selectedJob=151778056

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=44e41af5142433bd87a37656f2e41f617db5cf0f&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=success&filter-searchStr=cf9dd78470facc9cb169c7da4316c1bd9c3c7121

https://hg.mozilla.org/integration/autoland/rev/44e41af5142433bd87a37656f2e41f617db5cf0f

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8936904 [details]
Bug 1425294 - Use a hardcoded background color for mozscreenshots so the APNG will not have transparency.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/207622/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63eff267ee3a
Use a hardcoded background color for mozscreenshots so the APNG will not have transparency. r=MattN

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/63eff267ee3a