Closed
Bug 1425294
Opened 7 years ago
Closed 7 years ago
Use a hardcoded background color for mozscreenshots so the APNG will not have transparency
Categories
(Testing :: mozscreenshots, enhancement)
Tracking
(firefox59 fixed)
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: jaws, Assigned: jaws)
Details
Attachments
(1 file)
Bug 1419840 removed the parts of the screenshot that aren't included by the selectors, but the APNG that is shown on the mozscreenshots comparison tool is confusing because it will show transparent parts and then the diff frame will not show that same part as transparent.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8936904 [details]
Bug 1425294 - Use a hardcoded background color for mozscreenshots so the APNG will not have transparency.
https://reviewboard.mozilla.org/r/207622/#review213516
Attachment #8936904 -
Flags: review?(MattN+bmo) → review+
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/950963c8a8e1
Use a hardcoded background color for mozscreenshots so the APNG will not have transparency. r=MattN
Comment 4•7 years ago
|
||
Backed out changeset 950963c8a8e1 (bug 1425294) for failing ss in browser/tools/mozscreenshots/browser_screenshots_cropping.js
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=950963c8a8e193b0c52f72c5563f38f6b6f0056e&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=success&filter-searchStr=cf9dd78470facc9cb169c7da4316c1bd9c3c7121&selectedJob=151778056
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=44e41af5142433bd87a37656f2e41f617db5cf0f&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=success&filter-searchStr=cf9dd78470facc9cb169c7da4316c1bd9c3c7121
https://hg.mozilla.org/integration/autoland/rev/44e41af5142433bd87a37656f2e41f617db5cf0f
Flags: needinfo?(jaws)
Comment hidden (mozreview-request) |
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/63eff267ee3a
Use a hardcoded background color for mozscreenshots so the APNG will not have transparency. r=MattN
Comment 7•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(jaws)
You need to log in
before you can comment on or make changes to this bug.
Description
•