1425303 - Add ability to open gecko profiling treeherder job artifacts directly into the perf.html viewer

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement)

Description

[Robert Wood [:rwood]]

When --geckoProfiling is turned on (try flag) for talos performance tests, the resulting profile files are uploaded and a link is provided in treeherder artifacts for that selected job.

The next step, is to add a link for each profile artifact, that will enable directly opening the profile in https://perf-html.io/ so the profile can be analyzed easily.

Comment 1

[Robert Wood [:rwood]]

This requires support on the perf-html.io side to be able to open profile.zip files via /from-url/. This is already entered as a perf-html github issue here:

https://github.com/devtools-html/perf.html/issues/255

Once that is resolved, then we can add a perf-html.io formatted URL link on the 'Job Details' treeherder panel to automatically open the resulting talos *-profile.zip in a new tab in perf-html.io.

:gregtatum, any idea of the ETA for the above perf-html.io github issue to be resolved? I can work on the treeherder link side once the zip file support is in.

Comment 2

[Greg Tatum [:gregtatum]]

We can re-prioritize it since it's blocking you. I'll talk with the team to hopefully get it prioritized on our current sprint.

Comment 3

[Robert Wood [:rwood]]

(In reply to Greg Tatum [:gregtatum] [@gregtatum] from comment #2)
> We can re-prioritize it since it's blocking you. I'll talk with the team to
> hopefully get it prioritized on our current sprint.

Great thanks! :)

Comment 4

[Greg Tatum [:gregtatum]]

This is coming along, and getting closer: https://github.com/devtools-html/perf.html/issues/255

Comment 5

[Robert Wood [:rwood]]

Thanks Greg (perf-html.io now accepts URLs to zipfiles).

Next step: I'll attempt a patch that will add a 'open in perf-html.io' link on the Treeherder Job Details panel, beside talos gecko profile artifacts. Similar to the "open in test results viewer" link that appears beside raw log artifacts in the same panel.

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3389

Comment 7

[Ed Morley [:emorley]]

Comment on attachment 8964637 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3389

Left a comment :-)

Comment 8

[Robert Wood [:rwood]]

Thanks Ed for trying that out.

Hi Greg, for some reason the perf-html.io link that my treeherder patch generates works for me but doesn't work for :emorley. I must be doing something wrong... can you please have a look? I must be missing something. Thanks!

The conversation is in the pull request:

https://github.com/mozilla/treeherder/pull/3389#discussion_r179142583

Comment 9

[Robert Wood [:rwood]]

:gtatum, it looks like if the perf-html.io add-on isn't installed (or updated) then the link 404's. Is there any way instead of 404'ing, maybe perf-html.io could indicate that the add-on needs to be installed?

Comment 10

[Robert Wood [:rwood]]

Turns out the addon shouldn't be required, and the 404's are a bug. Markus filed a perf-html.io issue:

https://github.com/devtools-html/perf.html/issues/903

Comment 11

[Robert Wood [:rwood]]

Note: Keep the talos profiling documentation up to date after this eventually lands

https://wiki.mozilla.org/Performance_sheriffing/Talos/Profiling

Comment 12

[Panos Astithas (he/him) [:past] (please ni?)]

Is there anything else that needs to be done on our side to move this forward?

Comment 13

[Robert Wood [:rwood]]

Comment on attachment 8964637 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3389

(In reply to Panos Astithas [:past] (please ni?) from comment #12)
> Is there anything else that needs to be done on our side to move this
> forward?

No, now that the fix has been landed (comment 10) we should be good to land this.

:emorley can you please try the link in the PR again? Working fine for me. Thanks!

Comment 14

[Ed Morley [:emorley]]

Comment on attachment 8964637 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3389

Looks good :-)

Comment 15

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/db7d0e9de79d45dbf2047b4e0bdcc44fcb212b65
Bug 1425303 - Add perf-html.io link for talos gecko profiles (#3389)

Comment 16

[Robert Wood [:rwood]]

Thanks Ed! :)

Comment 17

[Panos Astithas (he/him) [:past] (please ni?)]

\o/