1425340 - DisplayItemScrollClip is unused

Status: RESOLVED FIXED

(Core :: Web Painting, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

https://marco-c.github.io/code-coverage-reports/#layout/painting shows that DisplayItemScrollClip.cpp is a file that has zero code coverage in our tests.

It was added in https://hg.mozilla.org/mozilla-central/rev/7d23d87b02f819e3c4ccb6d713d64af8488c645f .

I suspect that it should have been removed in https://hg.mozilla.org/mozilla-central/rev/2023dadca59c .  Should it?

Comment 1

[Markus Stange [:mstange]]

Yes, both the .cpp and the .h file should have been removed in that changeset (and the references in moz.build). Good catch!

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1425340 - Remove unused DisplayItemScrollClip files.

Review commit: https://reviewboard.mozilla.org/r/207670/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/207670/

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8936940 [details]
Bug 1425340 - Remove unused DisplayItemScrollClip files.

https://reviewboard.mozilla.org/r/207670/#review213568

Comment 4

[Marco Castelluccio [:marco]]

I guess this can land now? :)

Comment 5

[Markus Stange [:mstange]]

oops

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2afca7ece7b7
Remove unused DisplayItemScrollClip files. r=mattwoodrow

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2afca7ece7b7