51 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
Yesterday, it happened 9 times that Tecken was unable to write to Postgres that a missing symbol was actually missing. The logging of missing symbols is not strictly that important to the main task of asking Tecken if it exists. OperationalError can be swallowed in the case of logging missing symbols.
Created attachment 8937492 [details] [review] Link to GitHub pull-request: https://github.com/mozilla-services/tecken/pull/619
Hmm... on second thought, this (^ see PR) might be wrong. Instead of swallowing the error, perhaps a better approach would be to execute the failed DB write in a Celery job if it can't be done in the "main process". Which begs the question, is it better to do ALL these DB writes in Celery workers?
Commit pushed to master at https://github.com/mozilla-services/tecken https://github.com/mozilla-services/tecken/commit/8bd52ae56878d18c1fa91b0dbfdee353678649f7 fixes bug 1425442 - Avoid OperationalError when logging missing symbol (#619)
Status: NEW → RESOLVED
Last Resolved: a month ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.