1425449 - The first and second New Tab don't have a favicon

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[Mehmet]

Attachment: New_Tab_favicon.mov

59.0a1 (2017-12-15) (64-Bit)
macOS 10.12.6

STR:

1) Open a new window with three New Tabs

Actual: New Tab #1 and #2 don't have a favicon. But #3 has it.

Expected: All tabs should show it (or hide them at all)

A screencast is attached.

This seems to be recent regression from yesterdays build to today.

Thanks.

Comment 1

[Ed Lee :Mardak]

The first new tab is about:home. The second new tab is not preloaded.

Comment 2

[Ed Lee :Mardak]

Looks like the icon is first appearing then disappearing?

Comment 3

[Ed Lee :Mardak]

Sorry, in comment 1 I meant to clarify that the first tab about:home (never preloaded) and second tab is about:newtab (not preloaded). Subbsequent about:newtab opened after the first about:newtab should be preloaded.

So probably something about preloaded about:newtabs not triggering some code path that happens for "regular" page loads.?

Comment 4

[Mehmet]

(In reply to Ed Lee :Mardak from comment #2)
> Looks like the icon is first appearing then disappearing?

Yes, correct. It appears and disappears again.

Comment 5

[Ed Lee :Mardak]

johannh, I would guess from comment 3 that some default icon behavior is happening when the page loads "normally" (e.g., to clear the icon if a regular website doesn't have an icon ??). Preloaded pages are already loaded, so they don't trigger the usual progress listeners.

Comment 6

[Johann Hofmann [:johannh]]

This will get fixed in bug 1422903.

Comment 7

[Mehmet]

Attachment: missing_favicons_NewTabPage.mov

Just only for your information: It seems that it does not happen only on the first and second new tab. The favicon also disappears, if you open some new tab quickly in succession.

A screencast is attached.

Thanks for looking into it.

Comment 8

[Ed Lee :Mardak]

Fixed by bug 1422903
https://hg.mozilla.org/mozilla-central/rev/a618b142d9dc

Comment 9

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 59.0a1 (2017-12-15) on Windows 10, 64 Bit!

This bug's fix is verified with latest Nightly!

Build ID   : 20180120100135
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0