1425483 - On Mac, with RTL languages, CMD+Left/Right goes in wrong direction

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[Michael]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_2) AppleWebKit/604.4.7 (KHTML, like Gecko) Version/11.0.2 Safari/604.4.7

Steps to reproduce:

It happens on a Mac.
Does not happen on Windows.

Tested with Firefox 56, 57, 58 and 58 Developer Edition.

Steps:
- Go to google.com
- Set input language as Hebrew (I guess this happens in other RTL languages too)
- Write a sentence, such as מה נשמע מותק
- Click cmd+right or cmd+left a few times
- Select words via alt+shift+left or alt+shift+right a few times

Note that word-by-word movement with alt+left/right works as expected.
With English everything works as expected.


Actual results:

When clicking cmd+right, caret goes to the left end of the sentence.
When clicking cmd+left, caret goes to the right end of of the sentence.
When selecting words with alt+shift+right, selection moves to the left.
When selecting words with alt+shift+left, selection moves to the right.


Expected results:

When clicking cmd+right, caret should go to the right end of the sentence.
When clicking cmd+left, caret should go to the left end of of the sentence.
When selecting words with alt+shift+right, selection should move to the right.
When selecting words with alt+shift+left, selection should move to the left.

Comment 1

[Michael]

A year later, the issue still persists.
Now tested on Firefox 65.0.1
I'm on macOS Mojave 10.14.3

Comment 2

[Josh Aas]

A lot of discussion in bug 1138419 is relevant here.

Comment 3

[Josh Aas]

Attachment: Bug 1425483 - Fix cmd-left, cmd-right, cmd-shift-left, cmd-shift-right in RTL text fields on macOS. r?spohl,masayuki

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/19613b504384
https://hg.mozilla.org/integration/autoland/rev/a51af07a7efb
Fix cmd-left, cmd-right, cmd-shift-left, cmd-shift-right in RTL text fields on macOS. r=spohl,masayuki

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a51af07a7efb

Comment 6

[Josh Aas]

Release Note Request (optional, but appreciated)
[Why is this notable]: Fixes pretty noticeable bug in RTL text editing, a bunch of arrow-based commands go the wrong direction
[Affects Firefox for Android]: No
[Suggested wording]: Fixed a number of text editing commands involving arrow keys in right-to-left languages on macOS.
[Links (documentation, blog post, etc)]:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Added to the Fx152 relnotes.