1425485 - overscroll-behavior has no effect for <textarea>

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Botond Ballo [:botond]]

STR:
  1. Load the attached testcase in Firefox Nightly
  2. Use the mousewheel/trackpad to scroll down over the
     textarea.
  3. After the textarea scrolls to the bottom, continue
     scrolling down.

Expected results:
  Since the textarea is marked overscroll-behavior:contain,
  the page does not scroll down.

Actual results:
  The page scrolls down.

Comment 1

[Botond Ballo [:botond]]

Attachment: Testcase

Comment 2

[Botond Ballo [:botond]]

We fixed the same issue for scroll-behavior a year ago: bug 1320200.

Comment 3

[Botond Ballo [:botond]]

Attachment: Bug 1425485 - Propagate overscroll-behavior on a text input to the anonymous scrollable <div> inside it.

Review commit: https://reviewboard.mozilla.org/r/207808/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/207808/

Comment 4

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8937109 [details]
Bug 1425485 - Propagate overscroll-behavior on a text input to the anonymous scrollable <div> inside it.

https://reviewboard.mozilla.org/r/207808/#review213698

Should we just reuse inherit-scroll-behavior? Seems like we only need one class here.

Comment 5

[Botond Ballo [:botond]]

Attachment: Bug 1425485 - Propagate overscroll-behavior on a text input to the anonymous scrollable <div> inside it.

Review commit: https://reviewboard.mozilla.org/r/207850/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/207850/

Comment 6

[Botond Ballo [:botond]]

Comment on attachment 8937141 [details]
Bug 1425485 - Propagate overscroll-behavior on a text input to the anonymous scrollable <div> inside it.

Carrying r+ (not making this a new revision of the earlier review was a MozReview fail).

Comment 7

[Botond Ballo [:botond]]

Comment on attachment 8937141 [details]
Bug 1425485 - Propagate overscroll-behavior on a text input to the anonymous scrollable <div> inside it.

I guess I can't actually do that with MozReview. Timothy, could you re-r+ please?

Comment 8

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8937141 [details]
Bug 1425485 - Propagate overscroll-behavior on a text input to the anonymous scrollable <div> inside it.

https://reviewboard.mozilla.org/r/207850/#review213724

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99fe32dcca1c
Propagate overscroll-behavior on a text input to the anonymous scrollable <div> inside it. r=tnikkel

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/99fe32dcca1c