1425502 - Clear all macOS notifications before starting mozscreenshots

Status: RESOLVED FIXED

(Testing :: mozscreenshots, enhancement)

Description

[Matthew N. [:MattN]]

+++ This bug was initially created as a clone of Bug #1419506 +++

We're using the mochitest framework for the screenshots tool that the Firefox team uses to catch unwanted changes in the UI.

See attachment 8930582 [details] for one of the screenshots we captured recently. There are some OS upgrade notices and a nag for trying out Safari that are adding noise to the screenshot. This will likely result in false positives when we're doing automated comparisons.

==
I have a workaround until we have the proper solution in bug 1419506.

Comment 1

[Matthew N. [:MattN]]

Attachment: Bug 1425502 - Disable macOS notification center UI before starting mozscreenshots.

Review commit: https://reviewboard.mozilla.org/r/209030/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209030/

Comment 2

[Matthew N. [:MattN]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=15ffc92a5b5f2955815d7f7b30744bcc7a8df48a&filter-searchStr=test-macosx64%2Fopt-browser-screenshots-e10s&group_state=expanded

This approach won't work in new macOS versions if we don't disable System Integrity Protection but will work for now it seems.

Comment 3

[Johann Hofmann [:johannh]]

Comment on attachment 8938261 [details]
Bug 1425502 - Disable macOS notification center UI before starting mozscreenshots.

https://reviewboard.mozilla.org/r/209030/#review214782

Doesn't this alter test machines in a way that could cause breakage for other tests that are run afterwards? The JS code itself looks good to me, but you should probably get review from jmaher or someone else to make sure they're aware that we're doing this.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8938261 [details]
Bug 1425502 - Disable macOS notification center UI before starting mozscreenshots.

https://reviewboard.mozilla.org/r/209030/#review214788

this change looks fine.  I wonder if we should put this in test harness code so that we benefit from this on all harnesses?  One concern with that is we could get notifications as part of the harness setup/process launching, so this might be the more reliable approach.  r+ as this is good, thought I would suggest another approach and if you think that is worthwhile, file a bug and I can get it circulated somewhere on my team.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eec39dd09991
Disable macOS notification center UI before starting mozscreenshots. r=jmaher,johannh

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/eec39dd09991