1425540 - config.status --dry-run writes out Tupfiles with the tup backend

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Michael Shal [:mshal]]

Similar to bug 1424417, the tup backend writes out Tupfiles when --dry-run is specified. Fixing this is slightly harder than that bug, because config_status sets the dry_run attribute on the TupBackend object instead of the TupOnly object, and it's the latter that writes out Tupfiles.

Comment 1

[Michael Shal [:mshal]]

Attachment: Bug 1425540 - Support --dry-run in the tup backend;

Now that bug 1454771 has simplified the TupBackend class, it is much
easier to pass in the self.dry_run flag into BackendTupfile to avoid
writing out Tupfiles when --dry-run is used.

Review commit: https://reviewboard.mozilla.org/r/240052/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/240052/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8971282 [details]
Bug 1425540 - Support --dry-run in the tup backend;

https://reviewboard.mozilla.org/r/240052/#review245908

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a020203cc6f
Support --dry-run in the tup backend; r=chmanchester

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9a020203cc6f