Closed Bug 1425547 Opened 2 years ago Closed 2 years ago

Remove unused methods from nsIHTMLInlineTableEditor

Categories

(Core :: Editor, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox59 --- wontfix
firefox60 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file)

inlineTableEditingEnabled and refreshInlineTableEditingUI are used by bluegriffon, but others aren't used by m-c, c-c and bluegriffon.  Let's remove this from nsIHTMLInlineTableEditor.idl
Assignee: nobody → m_kato
Comment on attachment 8944224 [details]
Bug 1425547 - Remove unused methods from nsIHTMLInlineTableEditor.

https://reviewboard.mozilla.org/r/214506/#review220446

::: editor/libeditor/HTMLEditorEventListener.cpp:214
(Diff revision 1)
> -  nsCOMPtr<nsIDOMElement> element = do_QueryInterface(target);
> +  nsCOMPtr<Element> element = do_QueryInterface(target);
>  
>    RefPtr<HTMLEditor> htmlEditor = mEditorBase->AsHTMLEditor();
>    MOZ_ASSERT(htmlEditor);
> -  htmlEditor->DoInlineTableEditingAction(element);
> +  htmlEditor->DoInlineTableEditingAction(*element);

This doesn't guarantee that element is always non-nullptr. So, you should call DoInlineTableEditingAction() only when element is no nullptr (its old behavior is, returning an error if element is nullptr and the result was ignored).
Attachment #8944224 - Flags: review?(masayuki) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c208e865749a
Remove unused methods from nsIHTMLInlineTableEditor. r=masayuki
Comment on attachment 8944224 [details]
Bug 1425547 - Remove unused methods from nsIHTMLInlineTableEditor.

https://reviewboard.mozilla.org/r/214506/#review220764
Attachment #8944224 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c208e865749a#l3.58
> +HTMLEditor::DoInlineTableEditingAction(Element& aElement)

Why isn't the parameter type `const Element&`?
Flags: needinfo?(m_kato)
https://hg.mozilla.org/mozilla-central/rev/c208e865749a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Depends on: 1433100
Flags: needinfo?(m_kato)
You need to log in before you can comment on or make changes to this bug.