1425547 - Remove unused methods from nsIHTMLInlineTableEditor

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Makoto Kato [:m_kato]]

inlineTableEditingEnabled and refreshInlineTableEditingUI are used by bluegriffon, but others aren't used by m-c, c-c and bluegriffon.  Let's remove this from nsIHTMLInlineTableEditor.idl

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1425547 - Remove unused methods from nsIHTMLInlineTableEditor.

inlineTableEditingEnabled and refreshInlineTableEditingUI are used by
bluegriffon, but other methods aren't used by m-c, c-c and bluegriffon.
So I would like to remove these methods.  Then we can clean up
DoInlineTableEditingAction.

Review commit: https://reviewboard.mozilla.org/r/214506/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214506/

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8944224 [details]
Bug 1425547 - Remove unused methods from nsIHTMLInlineTableEditor.

https://reviewboard.mozilla.org/r/214506/#review220446

::: editor/libeditor/HTMLEditorEventListener.cpp:214
(Diff revision 1)
> -  nsCOMPtr<nsIDOMElement> element = do_QueryInterface(target);
> +  nsCOMPtr<Element> element = do_QueryInterface(target);
>  
>    RefPtr<HTMLEditor> htmlEditor = mEditorBase->AsHTMLEditor();
>    MOZ_ASSERT(htmlEditor);
> -  htmlEditor->DoInlineTableEditingAction(element);
> +  htmlEditor->DoInlineTableEditingAction(*element);

This doesn't guarantee that element is always non-nullptr. So, you should call DoInlineTableEditingAction() only when element is no nullptr (its old behavior is, returning an error if element is nullptr and the result was ignored).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c208e865749a
Remove unused methods from nsIHTMLInlineTableEditor. r=masayuki

Comment 4

[Makoto Kato [:m_kato]]

Comment on attachment 8944224 [details]
Bug 1425547 - Remove unused methods from nsIHTMLInlineTableEditor.

https://reviewboard.mozilla.org/r/214506/#review220764

Comment 5

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c208e865749a#l3.58
> +HTMLEditor::DoInlineTableEditingAction(Element& aElement)

Why isn't the parameter type `const Element&`?

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c208e865749a