Move clearOutput from the jsterm

RESOLVED FIXED in Firefox 62

Status

enhancement
P1
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: nchevobbe, Assigned: bgrins)

Tracking

(Blocks 1 bug)

Trunk
Firefox 62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 wontfix, firefox60 wontfix, firefox61 wontfix, firefox62 fixed)

Details

(Whiteboard: [boogaloo-mvp])

Attachments

(1 attachment)

There is no reason this would be handled in the jsterm.
Instead of calling this function, we should call hud.newConsoleOutput.dispatchMessagesClear() which is then picked up by redux
It looks like there's also a "messages-cleared" event, but AFAICT it's only used by a GCLI command and a couple of tests so it could probably be removed.
clearOutput also deals with network messages, although it maybe that should be handled in dispatchMessagesClear as well?

At the least we could move the existing clearOutput and clearPrivateMessages onto the hud object and call that instead of jsterm.clearOutput.
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Depends on: 1460841
Priority: -- → P1
Whiteboard: [boogaloo-mvp]
This patch just moves the existing functions onto the webconsole frame object. Note that `jsterm.hud` is actually referring to the webconsole frame aka `hud.ui` and not the hud itself. We should clean that up separately (rename it to jsterm.ui or similar).
Comment on attachment 8982636 [details]
Bug 1425552 - Move clearOutput and clearPrivateMessages from the jsterm and onto the WebConsoleFrame;

https://reviewboard.mozilla.org/r/248602/#review254888

Looks good to me, thanks Brian. Let's push this if TRY is green
Attachment #8982636 - Flags: review?(nchevobbe) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 87b75b2ab01ccdb0c49c24844d860da9d308b575 -d b1f676207e7b: rebasing 466561:87b75b2ab01c "Bug 1425552 - Move clearOutput and clearPrivateMessages from the jsterm and onto the WebConsoleFrame;r=nchevobbe" (tip)
merging devtools/client/scratchpad/test/browser_scratchpad_wrong_window_focus.js
merging devtools/client/shared/webpack/shims/jsterm-stub.js
merging devtools/client/webconsole/components/JSTerm.js
merging devtools/client/webconsole/console-commands.js
merging devtools/client/webconsole/test/mochitest/browser_console.js
merging devtools/client/webconsole/test/mochitest/browser_console_consolejsm_output.js
merging devtools/client/webconsole/test/mochitest/browser_jsterm_completion.js
merging devtools/client/webconsole/test/mochitest/browser_jsterm_dollar.js
merging devtools/client/webconsole/test/mochitest/browser_jsterm_error_docs.js
merging devtools/client/webconsole/test/mochitest/browser_jsterm_helper_help.js
merging devtools/client/webconsole/test/mochitest/browser_jsterm_hide_when_devtools_chrome_enabled_false.js
merging devtools/client/webconsole/test/mochitest/browser_jsterm_history.js
merging devtools/client/webconsole/test/mochitest/browser_jsterm_selfxss.js
merging devtools/client/webconsole/test/mochitest/browser_webconsole_cd_iframe.js
merging devtools/client/webconsole/test/mochitest/browser_webconsole_console_logging_workers_api.js
merging devtools/client/webconsole/test/mochitest/browser_webconsole_context_menu_copy_entire_message.js
merging devtools/client/webconsole/test/mochitest/browser_webconsole_context_menu_copy_link_location.js
merging devtools/client/webconsole/test/mochitest/browser_webconsole_context_menu_open_url.js
merging devtools/client/webconsole/test/mochitest/browser_webconsole_csp_violation.js
merging devtools/client/webconsole/test/mochitest/browser_webconsole_cspro.js
merging devtools/client/webconsole/test/mochitest/browser_webconsole_file_uri.js
merging devtools/client/webconsole/test/mochitest/browser_webconsole_highlighter_console_helper.js
merging devtools/client/webconsole/test/mochitest/browser_webconsole_hpkp_invalid-headers.js
merging devtools/client/webconsole/test/mochitest/browser_webconsole_hsts_invalid-headers.js
merging devtools/client/webconsole/test/mochitest/browser_webconsole_input_focus.js
merging devtools/client/webconsole/test/mochitest/browser_webconsole_loglimit.js
merging devtools/client/webconsole/test/mochitest/browser_webconsole_network_messages_expand.js
merging devtools/client/webconsole/test/mochitest/browser_webconsole_output_order.js
merging devtools/client/webconsole/test/mochitest/browser_webconsole_sandbox_update_after_navigation.js
merging devtools/client/webconsole/test/mochitest/browser_webconsole_script_errordoc_urls.js
merging devtools/client/webconsole/test/mochitest/browser_webconsole_select_all.js
merging devtools/client/webconsole/test/mochitest/browser_webconsole_time_methods.js
merging devtools/client/webconsole/test/mochitest/head.js
merging devtools/client/webconsole/webconsole-connection-proxy.js
merging devtools/client/webconsole/webconsole-frame.js
warning: conflicts while merging devtools/client/scratchpad/test/browser_scratchpad_wrong_window_focus.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging devtools/client/webconsole/console-commands.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging devtools/client/webconsole/test/mochitest/browser_jsterm_completion.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging devtools/client/webconsole/test/mochitest/browser_jsterm_selfxss.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging devtools/client/webconsole/test/mochitest/browser_webconsole_console_logging_workers_api.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging devtools/client/webconsole/test/mochitest/browser_webconsole_context_menu_copy_entire_message.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging devtools/client/webconsole/test/mochitest/browser_webconsole_context_menu_copy_link_location.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging devtools/client/webconsole/test/mochitest/browser_webconsole_context_menu_open_url.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging devtools/client/webconsole/test/mochitest/browser_webconsole_csp_violation.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging devtools/client/webconsole/test/mochitest/browser_webconsole_loglimit.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging devtools/client/webconsole/test/mochitest/browser_webconsole_output_order.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging devtools/client/webconsole/test/mochitest/browser_webconsole_sandbox_update_after_navigation.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5834b41d97cd
Move clearOutput and clearPrivateMessages from the jsterm and onto the WebConsoleFrame;r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/5834b41d97cd
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.