Closed Bug 1425596 Opened 3 years ago Closed 3 years ago

Stop busy looping in mFakeAudioDevice

Categories

(Core :: WebRTC: Audio/Video, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: padenot, Assigned: padenot)

References

Details

Attachments

(1 file)

This is a workaround for the fact that our code is wrong.

FakeAudioDeviceModule :::TimeUntilNextProcess() returns 0, so we're busy looping.

I'm switching that to 100, which is arbitrary, but makes the problem go away. I want to fix that soon, because this is a terrible workaround.

FakeAudioDeviceModule is _not_ made to be used in production.
Comment on attachment 8937194 [details]
Bug 1425596 - Stop busy looping in mFakeAudioDevice.

https://reviewboard.mozilla.org/r/207902/#review213762

out of necessity
Attachment #8937194 - Flags: review?(jyavenard) → review+
Blocks: 1425598
Assignee: nobody → padenot
padenot: Once you're off a plane (or if you have satellite internet; unlikely), please land ASAP; thanks.
And we may need a better solution before this uplifts to beta; or uplift a fix into beta
Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d98062d7d66b
Stop busy looping in mFakeAudioDevice. r=jya
https://hg.mozilla.org/mozilla-central/rev/d98062d7d66b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.