1425623 - Avoid heap memory allocation on MSG::UpdateGraph

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, enhancement)

Description

[Jean-Yves Avenard [:jya]]

Spawn from bug 1404997 comment 19.

See how we can fully remove heap memory allocation from cubeb's MSG audio callback

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1425623 - Don't allocate array on the heap.

Instead allocate it on the stack and provide it as out parameter.

Review commit: https://reviewboard.mozilla.org/r/208024/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208024/

Comment 2

[Paul Adenot (:padenot)]

Comment on attachment 8937342 [details]
Bug 1425623 - Don't allocate array on the heap.

https://reviewboard.mozilla.org/r/208024/#review213866

::: dom/media/MediaStreamGraph.cpp:1153
(Diff revision 1)
>    UpdateStreamOrder();
>  
>    bool ensureNextIteration = false;
>  
>    // Grab pending stream input and compute blocking time
>    // TODO: Ensure that heap memory allocations isn't going to be a problem.

This comment can be removed now.

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8937342 [details]
Bug 1425623 - Don't allocate array on the heap.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/208024/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/017630a4b371
Don't allocate array on the heap. r=padenot

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/017630a4b371