Closed
Bug 1425623
Opened 6 years ago
Closed 6 years ago
Avoid heap memory allocation on MSG::UpdateGraph
Categories
(Core :: Audio/Video: MediaStreamGraph, enhancement)
Core
Audio/Video: MediaStreamGraph
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: jya, Assigned: jya)
Details
Attachments
(1 file)
Spawn from bug 1404997 comment 19. See how we can fully remove heap memory allocation from cubeb's MSG audio callback
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8937342 [details] Bug 1425623 - Don't allocate array on the heap. https://reviewboard.mozilla.org/r/208024/#review213866 ::: dom/media/MediaStreamGraph.cpp:1153 (Diff revision 1) > UpdateStreamOrder(); > > bool ensureNextIteration = false; > > // Grab pending stream input and compute blocking time > // TODO: Ensure that heap memory allocations isn't going to be a problem. This comment can be removed now.
Attachment #8937342 -
Flags: review?(padenot) → review+
Comment hidden (mozreview-request) |
Pushed by jyavenard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/017630a4b371 Don't allocate array on the heap. r=padenot
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/017630a4b371
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•