Closed
Bug 1425626
Opened 7 years ago
Closed 7 years ago
Intermittent tests\jit-test\jit-test\tests\baseline\bug1416727.js | Z:\task_1513379192\build\tests\jit-test\jit-test\tests\baseline\bug1416727.js:15:19 InternalError: too much recursion (code 3, args "") [0.0 s]
Categories
(Core :: JavaScript Engine, defect, P5)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: jandem)
References
Details
(Keywords: intermittent-failure)
Filed by: philringnalda [at] gmail.com https://treeherder.mozilla.org/logviewer.html#?job_id=151906012&repo=mozilla-inbound https://queue.taskcluster.net/v1/task/WNhEekJXTNO4WvqGMb8IYA/runs/0/artifacts/public/logs/live_backing.log
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 12•7 years ago
|
||
This is permafailing for me on win32 PGO builds when I run Try pushes with an updated version of VS2017. Is this the ol' "increase the stack limit" exercise again?
Flags: needinfo?(jdemooij)
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 14•7 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #12) > This is permafailing for me on win32 PGO builds when I run Try pushes with > an updated version of VS2017. Is this the ol' "increase the stack limit" > exercise again? I added that try-catch at the end of the test to ignore these overrecursion errors, but apparently that's not sufficient. I'm not sure why - I wonder if we're overrecursing when trying to enter the catch block. We could replace |try { test(); } catch(e) {}| with just |test();| and add this line at the beginning of the file: // |jit-test| allow-overrecursed I can do that but I'd like to understand the failure a bit better. I'll do that today or tomorrow.
Assignee | ||
Comment 15•7 years ago
|
||
Oh I see. This test has an onExceptionUnwind debugger hook that will be invoked and that may land us in ReportErrorToGlobal -> EnvironmentPreparer::invoke where the shell will report the exception and set sc->exitCode. OK this is all working as expected and the test is broken.
Comment 16•7 years ago
|
||
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/292900fd9665 Properly allow overrecursion in bug1416727.js jit-test. r=me
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(jdemooij)
Comment 17•7 years ago
|
||
Thanks, Jan! Try confirms that did the trick :)
Comment 18•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/292900fd9665
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Assignee: nobody → jdemooij
You need to log in
before you can comment on or make changes to this bug.
Description
•