1425697 - Data Channel remote maximum message size slightly incorrect

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Lennart Grahl [:lgrahl]]

This should be a quick & easy fix. The default remote maximum message size is 65536 and not 65535.

(Apologies for messing this up in the first place.)

Comment 1

[Lennart Grahl [:lgrahl]]

Would it be possible to backport this trivial change to FF >= 57? Otherwise, we will need to add a workaround to adapter (https://github.com/webrtc/adapter/pull/702).

Comment 2

[Nils Ohlmeier [:drno]]

Attachment: Bug 1425697: WEBRTC_DATACHANNEL_MAX_MESSAGE_SIZE_REMOTE_DEFAULT++.

Review commit: https://reviewboard.mozilla.org/r/208350/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208350/

Comment 3

[Nils Ohlmeier [:drno]]

We might be able to uplift this to 58 Beta. But we won't be able to uplift this change to 57, as it's not a security fix.

BTW: Lennart is there a reference (e.g. spec) for this change from 65535 to 65536?

Comment 4

[Lennart Grahl [:lgrahl]]

It always was 65536. I just messed up and I guess everyone just assumed it is correct.

https://tools.ietf.org/html/draft-ietf-mmusic-sctp-sdp-26#section-6.1
"If the SDP 'max-message-size' attribute is not present, the default value is 64K." - which of course is 2^16 and not 2^16 - 1.

I'll add special treatment of the default remote MMS for FF 57 in adapter.

Comment 5

[Lennart Grahl [:lgrahl]]

Comment on attachment 8937651 [details]
Bug 1425697: WEBRTC_DATACHANNEL_MAX_MESSAGE_SIZE_REMOTE_DEFAULT++.

https://reviewboard.mozilla.org/r/208350/#review214136

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efee3a8c1124
WEBRTC_DATACHANNEL_MAX_MESSAGE_SIZE_REMOTE_DEFAULT++. r=lennart.grahl+594092

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/efee3a8c1124

Comment 8

[Julien Cristau [:jcristau]]

Please request uplift to beta when you get a chance.

Comment 9

[Nils Ohlmeier [:drno]]

Comment on attachment 8937651 [details]
Bug 1425697: WEBRTC_DATACHANNEL_MAX_MESSAGE_SIZE_REMOTE_DEFAULT++.

Approval Request Comment
[Feature/Bug causing the regression]: bug 979417
[User impact if declined]: WebRTC services need to use shims to fix the default buffer size for data channels to the correct value to make the behavior spec compliant.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: We only increase the default buffer size by one more byte.
[String changes made/needed]: N/A

Comment 10

[Gerry Chang [:gchang]]

Comment on attachment 8937651 [details]
Bug 1425697: WEBRTC_DATACHANNEL_MAX_MESSAGE_SIZE_REMOTE_DEFAULT++.

Fix a WebRTC data channel issue. Beta58+.

Comment 11

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4aaa982ec14e