1425824 - Stop packaging gcda files

Status: RESOLVED FIXED

(Testing :: Code Coverage, enhancement)

Description

[Marco Castelluccio [:marco]]

Both the code coverage code on mozilla-releng/services and ActiveData are now using the grcov ZIP artifact, so we can stop packaging the GCDA files too.

Joel, Kyle, can you think of anything that would still be using the GCDA artifacts?

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

I am not aware of anything, Kyle is afk until next year.

Comment 2

[Marco Castelluccio [:marco]]

If we do this, we can save ~20 MB per chunk on Linux and ~40 MB per chunk on Windows.

Comment 3

[Kyle Lahnakoski [:ekyle]]

The only thing I see that would use GCDA artifacts would be more accurate coverage using the flow control graph contained in the gcno files. Coverage by line can not tell us if a block of code with zero lines is never taken (think an if-block without an else clause: How do we know the else path is taken?). Also, coverage by line can not tell us what parts of a line are covered, or not. 

I do not expect us to use this information anytime soon, so I am all for removing GCDA artifacts.

Comment 4

[Marco Castelluccio [:marco]]

(In reply to Kyle Lahnakoski [:ekyle] from comment #3)
> The only thing I see that would use GCDA artifacts would be more accurate
> coverage using the flow control graph contained in the gcno files. Coverage
> by line can not tell us if a block of code with zero lines is never taken
> (think an if-block without an else clause: How do we know the else path is
> taken?). Also, coverage by line can not tell us what parts of a line are
> covered, or not. 
> 
> I do not expect us to use this information anytime soon, so I am all for
> removing GCDA artifacts.

We can also make grcov output it in the grcov info files if and when we'll need it, so let's nuke gcda artifacts for now!

Comment 5

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c21d8dfed525
Stop packaging gcda files. r=jmaher

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/c21d8dfed525