Closed Bug 1425824 Opened 3 years ago Closed 2 years ago

Stop packaging gcda files

Categories

(Testing :: Code Coverage, enhancement)

enhancement
Not set
normal

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: marco, Assigned: marco, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Both the code coverage code on mozilla-releng/services and ActiveData are now using the grcov ZIP artifact, so we can stop packaging the GCDA files too.

Joel, Kyle, can you think of anything that would still be using the GCDA artifacts?
I am not aware of anything, Kyle is afk until next year.
If we do this, we can save ~20 MB per chunk on Linux and ~40 MB per chunk on Windows.
Flags: needinfo?(klahnakoski)
Mentor: mcastelluccio
Keywords: good-first-bug
The only thing I see that would use GCDA artifacts would be more accurate coverage using the flow control graph contained in the gcno files. Coverage by line can not tell us if a block of code with zero lines is never taken (think an if-block without an else clause: How do we know the else path is taken?). Also, coverage by line can not tell us what parts of a line are covered, or not. 

I do not expect us to use this information anytime soon, so I am all for removing GCDA artifacts.
Flags: needinfo?(klahnakoski)
(In reply to Kyle Lahnakoski [:ekyle] from comment #3)
> The only thing I see that would use GCDA artifacts would be more accurate
> coverage using the flow control graph contained in the gcno files. Coverage
> by line can not tell us if a block of code with zero lines is never taken
> (think an if-block without an else clause: How do we know the else path is
> taken?). Also, coverage by line can not tell us what parts of a line are
> covered, or not. 
> 
> I do not expect us to use this information anytime soon, so I am all for
> removing GCDA artifacts.

We can also make grcov output it in the grcov info files if and when we'll need it, so let's nuke gcda artifacts for now!
Attached patch PatchSplinter Review
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8941185 - Flags: review?(jmaher)
Attachment #8941185 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/c21d8dfed525
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Depends on: 1430170
You need to log in before you can comment on or make changes to this bug.