1425832 - Using Services.prompt from pippki.js breaks browser_loadPKCS11Module_ui - should use PromptTestUtils

Status: NEW

(Core :: Security: PSM, defect, P3)

Description

[Mark Banner (:standard8)]

I've just been trying to enable mozilla/use-services for some files in security.

I was trying to replace this:

https://searchfox.org/mozilla-central/rev/b1e0ae2573e88391a7ed92407568be77994c9317/security/manager/pki/resources/content/pippki.js#67-69

with 

```
Services.prompt.alert(window, title, message);
```

Although the tests work, it was reporting leaks:

TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/mochitest/browser/browser_loadPKCS11Module_ui.js | leaked 1 window(s) until shutdown [url = chrome://pippki/content/load_device.xul]
TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/mochitest/browser/browser_loadPKCS11Module_ui.js | leaked 1 window(s) until shutdown [url = about:blank]

I can't quite work out why this would be. My only thought is that using Services.jsm is causing some initialisation to be tagged with the window (load_device.xul), and therefore it thinks not all of the window items get freed.

Bug 1418959 is another similar bug, but with Services.strings.

Not sure where to file this, so put it in general for now.

Comment 1

[:Gijs (he/him)]

I'm here because of bug 1808115. Would be useful to re-test this just to find out if the changes to how Services.jsm works have "fixed" this particular leak.

Comment 2

[Mark Banner (:standard8)]

(In reply to :Gijs (he/him) from comment #1)

I'm here because of bug 1808115. Would be useful to re-test this just to find out if the changes to how Services.jsm works have "fixed" this particular leak.

It appears it no longer leaks, but running it now causes this failure:

  FAIL alert() should have been called once - 0 == 1 - JS frame :: chrome://mochitests/content/browser/security/manager/ssl/tests/mochitest/browser/browser_loadPKCS11Module_ui.js :: testAddModuleFailure :: line 252

I think the test probably needs rewriting using PromptTestUtils, as Services.prompt is likely caching the prompt service and causing the mock to not be applied properly.