1425876 - Update Debugger Frontend (12-18)

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Comment 1

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=357058535b847de72d3dafa462515cae020e62a3

Comment 2

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e600909f8bd09a5508effd4b2bc4ff444bc1702

Comment 3

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=66035e3ce7866fd14621669a204ec42b668a1b32

Comment 4

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e6746f098a54155b2f3825504c1d02be5c04551

Comment 5

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5f6161092cd879009d47495eead4954fb1a11063

Comment 6

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3cab95f36ee71da35e97acd7c37f5128256a9266

Comment 7

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa2ed00d90d0b771607a8489cb1a4a1db8802b1d

Comment 8

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a709e73a99442366f3d0bd33cb547d63259f7bd0

Comment 9

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c6bb3ace7eb86856cfc6688d087a815ffa9be11

Comment 10

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1123e666e1657cc917929dc8e9bca9c8c4ca474f

Comment 11

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4cf26c91868a1014cfe4152cb1ed08bb2b82eb2c

Comment 12

[Jason Laster [:jlast]]

Attachment: patch-12-18-6.patch

Comment 14

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cabe125e98fa926e82723be4d527b4bca4d10b71

Comment 15

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=341a644fbc2fdacc4c9a3b89366d1363d3306d9d

Comment 16

[Jason Laster [:jlast]]

ignore the latest try runs :)

Comment 17

[Julian Descottes [:jdescottes]]

Comment on attachment 8937695 [details] [diff] [review]
patch-12-18-6.patch

Review of attachment 8937695 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Spotted one issue, not a regression, according to :jlast already being fixed:

When paused, editor always keeps scrolling back to the paused line. STRs:
- add a breakpoint on a source file big enough to have scrollbar
- hit breakpoint
- scroll somewhere else, try to add a breakpoint
=> breakpoint is added but scrolls immediately to the paused line, very surprising for the user

Comment 18

[Julian Descottes [:jdescottes]]

Can we get a commit list and some GH links, same as what you originally provided on Bug 1425912.

Thanks

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fbd296b011c1
Update Debugger frontend (12-18). r=jdescottes

Comment 20

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/fbd296b011c1

Comment 21

[Jason Laster [:jlast]]

I believe this is it.

https://github.com/devtools-html/debugger.html/compare/2d50f0e...2d9347c