Update Debugger Frontend (12-18)

RESOLVED FIXED in Firefox 59

Status

()

Firefox
Developer Tools: Debugger
P3
enhancement
RESOLVED FIXED
a month ago
28 days ago

People

(Reporter: jlast, Assigned: jlast, NeedInfo)

Tracking

(Blocks: 1 bug)

57 Branch
Firefox 59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 12

29 days ago
Created attachment 8937695 [details] [diff] [review]
patch-12-18-6.patch
Attachment #8937695 - Flags: review?(jdescottes)
(Assignee)

Updated

29 days ago
Duplicate of this bug: 1425912
Assignee: nobody → jlaster
Blocks: 1412334
Severity: normal → enhancement
Status: NEW → ASSIGNED
Priority: -- → P3
(Assignee)

Comment 16

29 days ago
ignore the latest try runs :)
Comment on attachment 8937695 [details] [diff] [review]
patch-12-18-6.patch

Review of attachment 8937695 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Spotted one issue, not a regression, according to :jlast already being fixed:

When paused, editor always keeps scrolling back to the paused line. STRs:
- add a breakpoint on a source file big enough to have scrollbar
- hit breakpoint
- scroll somewhere else, try to add a breakpoint
=> breakpoint is added but scrolls immediately to the paused line, very surprising for the user
Attachment #8937695 - Flags: review?(jdescottes) → review+
Can we get a commit list and some GH links, same as what you originally provided on Bug 1425912.

Thanks
Flags: needinfo?(jlaster)

Comment 19

29 days ago
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fbd296b011c1
Update Debugger frontend (12-18). r=jdescottes

Comment 20

28 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fbd296b011c1
Status: ASSIGNED → RESOLVED
Last Resolved: 28 days ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.