1425879 - Intermittent toolkit/components/passwordmgr/test/browser/browser_autocomplete_insecure_warning.js | Uncaught exception - Wait for warning to show - timed out after 50 tries.

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P2)

Description

[Treeherder Bug Filer]

Filed by: csabou [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=152126316&repo=autoland

https://queue.taskcluster.net/v1/task/KFfWlRTJQkm6rHwRp-bBNw/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Intermittent Failures Robot]

19 failures in 97 pushes (0.196 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* autoland: 16
* mozilla-inbound: 2
* mozilla-central: 1

Platform breakdown:
* osx-10-10: 17
* linux64: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1425879&startday=2017-12-18&endday=2017-12-18&tree=all

Comment 2

[Intermittent Failures Robot]

38 failures in 116 pushes (0.328 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* autoland: 21
* mozilla-inbound: 14
* try: 2
* mozilla-central: 1

Platform breakdown:
* osx-10-10: 37
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1425879&startday=2017-12-19&endday=2017-12-19&tree=all

Comment 3

[Cristina Coroiu [:ccoroiu]]

This bug is failing frequently, it has more than 80 failures since it was opened, 2 days ago. 

Most of the failures are on the OS X 10.10 and a few of them on Linux x64.
The most affected build is debug, but there are a few on asan and opt. 

An example of a recent log file: 
https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=152634562&lineNumber=25552

And a relevant part of the log: 
07:25:21     INFO - Buffered messages logged at 07:25:14
07:25:21     INFO - Entering test bound common_initialize
07:25:21     INFO - Leaving test bound common_initialize
07:25:21     INFO - Entering test bound test_clickInsecureFieldWarning
07:25:21     INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_autocomplete_insecure_warning.js | Got popup - 
07:25:21     INFO - Console message: [JavaScript Warning: "Password fields present in a form with an insecure (http://) form action. This is a security risk that allows user login credentials to be stolen." {file: "https://example.com/browser/toolkit/components/passwordmgr/test/browser/form_cross_origin_insecure_action.html" line: 0 column: 0 source: "0"}]
07:25:21     INFO - content window focused
07:25:21     INFO - Buffered messages logged at 07:25:15
07:25:21     INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_autocomplete_insecure_warning.js | autocomplete shown - 
07:25:21     INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_autocomplete_insecure_warning.js | Got warning richlistitem - 
07:25:21     INFO - Console message: [JavaScript Warning: "Use of nsIFile in content process is deprecated." {file: "resource://gre/modules/FileUtils.jsm" line: 174}]
07:25:21     INFO - Buffered messages finished
07:25:21     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/browser/browser_autocomplete_insecure_warning.js | Uncaught exception - Wait for warning to show - timed out after 50 tries.
07:25:21     INFO - Leaving test bound test_clickInsecureFieldWarning
07:25:21     INFO - GECKO(2179) | MEMORY STAT | vsize 4387MB | residentFast 357MB | heapAllocated 90MB
07:25:21     INFO - TEST-OK | toolkit/components/passwordmgr/test/browser/browser_autocomplete_insecure_warning.js | took 6847ms
07:25:21     INFO - Not taking screenshot here: see the one that was previously logged
07:25:21     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/browser/browser_autocomplete_insecure_warning.js | Found an unexpected tab at the end of test run: https://example.com/browser/toolkit/components/passwordmgr/test/browser/form_cross_origin_insecure_action.html - 
07:25:21     INFO - GECKO(2179) | ++DOCSHELL 0x11ceb5800 == 2 [pid = 2184] [id = {d7711b69-7362-ac4a-bcb5-d5a2264ff57f}]
07:25:21     INFO - GECKO(2179) | ++DOMWINDOW == 3 (0x10fb7f200) [pid = 2184] [serial = 3] [outer = 0x0]
07:25:21     INFO - GECKO(2179) | [Child 2183, Main Thread] WARNING: SendNotifyIMEFocus got rejected.: file /builds/worker/workspace/build/src/widget/PuppetWidget.cpp, line 846
07:25:21     INFO - GECKO(2179) | ++DOMWINDOW == 4 (0x11cec7400) [pid = 2184] [serial = 4] [outer = 0x10fb7f200]
07:25:21     INFO - checking window state
07:25:21     INFO - TEST-START | toolkit/components/passwordmgr/test/browser/browser_capture_doorhanger.js
07:25:21     INFO - GECKO(2179) | ++DOCSHELL 0x1233bd000 == 3 [pid = 2182] [id = {b3b5912e-26e3-be42-9cab-6345bdf97ede}]
07:25:21     INFO - GECKO(2179) | ++DOMWINDOW == 5 (0x1161805e0) [pid = 2182] [serial = 5] [outer = 0x0]
07:25:21     INFO - GECKO(2179) | ++DOMWINDOW == 6 (0x1233cdc00) [pid = 2182] [serial = 6] [outer = 0x1161805e0]
07:25:21     INFO - GECKO(2179) | [Child 2182, Main Thread] WARNING: site security information will not be persisted: file /builds/worker/workspace/build/src/security/manager/ssl/nsSiteSecurityService.cpp, line 554
07:25:21     INFO - GECKO(2179) | [Parent 2179, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057: file /builds/worker/workspace/build/src/netwerk/base/nsChannelClassifier.cpp, line 344
07:25:21     INFO - GECKO(2179) | ++DOMWINDOW == 7 (0x1233d7400) [pid = 2182] [serial = 7] [outer = 0x1161805e0]
07:25:21     INFO - GECKO(2179) | --DOMWINDOW == 6 (0x11bb4fc00) [pid = 2181] [serial = 2] [outer = 0x0] [url = about:blank]
07:25:21     INFO - GECKO(2179) | --DOMWINDOW == 5 (0x1107d4c00) [pid = 2181] [serial = 6] [outer = 0x0] [url = about:blank]
07:25:21     INFO - GECKO(2179) | console.warn: LoginRecipes: getRecipes: falling back to a synchronous message for: http://example.com

:MattN As you are the triage owner of this component, could you please take a look at this?
Thank you!

Comment 4

[Intermittent Failures Robot]

65 failures in 108 pushes (0.602 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* mozilla-inbound: 26
* autoland: 23
* try: 12
* mozilla-central: 4

Platform breakdown:
* osx-10-10: 51
* linux64: 14

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1425879&startday=2017-12-20&endday=2017-12-20&tree=all

Comment 5

[Matthew N. [:MattN]]

Nobody has touched this test recently, the only recent change that could affect this is bug 1410364 but that was q few weeks earlier.

Dolske, please advise on how to prioritize this pwmgr bug. JohannH and Sean Lee are others who could work on this.

Comment 6

[Geoff Brown [:gbrown]]

https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=osx%20browser-chrome&tochange=c2dcdbd994f1b2d0d981d765d97c947a62bb7c34&fromchange=2fcff634ec0ecbf116da887ab8831f846c7c962b strongly suggests this started with bug 1406585. (Note browser_autocomplete_insecure_warning.js ran in bc1 in earlier pushes, then moved to bc4.)

Comment 7

[Intermittent Failures Robot]

46 failures in 170 pushes (0.271 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* mozilla-inbound: 26
* autoland: 18
* mozilla-central: 2

Platform breakdown:
* osx-10-10: 36
* linux64: 10

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1425879&startday=2017-12-21&endday=2017-12-21&tree=all

Comment 8

[Intermittent Failures Robot]

18 failures in 50 pushes (0.36 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* autoland: 8
* mozilla-inbound: 6
* try: 3
* mozilla-central: 1

Platform breakdown:
* osx-10-10: 12
* linux64: 5
* macosx64-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1425879&startday=2017-12-22&endday=2017-12-22&tree=all

Comment 9

[Intermittent Failures Robot]

215 failures in 590 pushes (0.364 failures/push) were associated with this bug in the last 7 days. 

This is the #3 most frequent failure this week.   

** This test has failed more than 200 times in the last 30 days. It should be disabled until it can be fixed. ** 

Repository breakdown:
* autoland: 93
* mozilla-inbound: 84
* try: 19
* mozilla-central: 19

Platform breakdown:
* osx-10-10: 173
* linux64: 38
* macosx64-nightly: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1425879&startday=2017-12-18&endday=2017-12-24&tree=all

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cfd2b3029617
Disable browser_autocomplete_insecure_warning.js on linux and osx, for ongoing intermittent failures; r=me, a=test-only

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cfd2b3029617

Comment 12

[Intermittent Failures Robot]

32 failures in 147 pushes (0.218 failures/push) were associated with this bug in the last 7 days. 

This is the #4 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* mozilla-central: 14
* mozilla-inbound: 11
* autoland: 6
* try: 1

Platform breakdown:
* osx-10-10: 21
* linux64: 8
* macosx64-nightly: 2
* windows7-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1425879&startday=2017-12-25&endday=2017-12-31&tree=all

Comment 13

[Sean Lee [:seanlee][:weilonge]]

After removing the line [1] in the patch of bug 1406585, the bc1 test [2] in MacOS looks good. I will dive into this later once I finished other bugs.

[1] https://searchfox.org/mozilla-central/rev/51cd1093c5c2113e7b041e8cc5c9bf2186abda13/toolkit/components/satchel/AutoCompletePopup.jsm#118
[2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c2ab389514329cf6e753abff94ddeef100fd14b

Comment 14

[Intermittent Failures Robot]

1 failures in 462 pushes (0.002 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* try: 1

Platform breakdown:
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1425879&startday=2018-01-01&endday=2018-01-07&tree=all

Comment 15

[Intermittent Failures Robot]

1 failures in 702 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 1

Platform breakdown:
* windows10-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1425879&startday=2018-02-05&endday=2018-02-11&tree=all

Comment 16

[Intermittent Failures Robot]

1 failures in 718 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 1

Platform breakdown:
* windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1425879&startday=2018-06-25&endday=2018-07-01&tree=trunk

Comment 17

[Intermittent Failures Robot]

1 failures in 2545 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 1

Platform breakdown:
* windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1425879&startday=2018-08-27&endday=2018-09-02&tree=all

Comment 18

[Intermittent Failures Robot]

1 failures in 2684 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 1

Platform breakdown:
* windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1425879&startday=2018-09-10&endday=2018-09-16&tree=all

Comment 19

[Intermittent Failures Robot]

1 failures in 2708 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 1

Platform breakdown:
* windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1425879&startday=2018-10-01&endday=2018-10-07&tree=all

Comment 20

[Intermittent Failures Robot]

1 failures in 2584 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* try: 1

Platform breakdown:
* windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1425879&startday=2018-10-22&endday=2018-10-28&tree=all

Comment 21

[Justin Dolske [:Dolske]]

Declaring new-year needinfo bankruptcy.

Comment 22

[Florian Quèze [:florian]]

Attachment: Bug 1425879 - browser_autocomplete_insecure_warning.js should not rely on the implicit initial 100ms timer from waitForCondition, r=sfoster.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22f424db4ec7
browser_autocomplete_insecure_warning.js should not rely on the implicit initial 100ms timer from waitForCondition, r=sfoster.

Comment 24

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/22f424db4ec7