Closed Bug 1425884 Opened 3 years ago Closed 2 months ago

Intermittent browser/extensions/formautofill/test/browser/browser_creditCard_doorhanger.js | Uncaught exception - TypeError: form is null

Categories

(Toolkit :: Form Autofill, enhancement, P3)

Product:
Toolkit
Component:
Form Autofill
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla80
Tracking Flags:
Tracking Status
firefox60 --- disabled
firefox61 --- disabled
firefox80 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: jimm)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, Whiteboard: [cc-autofill-mvp])

Attachments

(3 files, 2 obsolete files)

Disabled on Linux, Windows, OSX debug
767 bytes, patch
jmaher
: review+
jmaher
: checkin+
Details | Diff | Splinter Review
Added "=" after "skip-if"
904 bytes, patch
jmaher
: review+
Details | Diff | Splinter Review
Bug 1425884 - Enable browser_creditCard_doorhanger.js.
47 bytes, text/x-phabricator-request
Details | Review 
Not sure how it could be reproduced cause autocomplete_creditcard_basic.html seems doesn't change recently. Let's see the reproduce rate in the following weeks.
See Also: → 1427217, 1426595, 1404453
See Also: → 1409658
Steve, Could you take a look? Thanks.
Flags: needinfo?(schung)
Whiteboard: [stockwell needswork]
Assignee: nobody → schung
Flags: needinfo?(schung)
This bug has failed 40 times in the last 7 days. It has failed on Linux, OS X, Windows 7 and Windows 10 affecting opt. debug and pgo build types.

Failing tests: mochitest-browser-chrome-e10

Link to a recent log: https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=163631538&lineNumber=4426

Part of that log:
08:05:07     INFO -  Buffered messages finished
08:05:07    ERROR -  916 INFO TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_creditCard_doorhanger.js | Uncaught exception - TypeError: form is null
08:05:07     INFO -  917 INFO Leaving test bound test_update_autofill_form_name
08:05:07     INFO -  918 INFO Entering test bound test_update_autofill_form_exp_date
08:05:07     INFO -  919 INFO expecting credit card saved
08:05:07     INFO -  920 INFO expecting record retrievals: creditCards
08:05:07     INFO -  Not taking screenshot here: see the one that was previously logged
08:05:07    ERROR -  921 INFO TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_creditCard_doorhanger.js | 1 credit card in storage - Got 2, expected 1
08:05:07     INFO -  Stack trace:
08:05:07     INFO -  chrome://mochikit/content/browser-test.js:test_is:1271
08:05:07     INFO -  chrome://mochitests/content/browser/browser/extensions/formautofill/test/browser/browser_creditCard_doorhanger.js:test_update_autofill_form_exp_date:523
08:05:08     INFO -  922 INFO expecting the target input being focused and indentified
08:05:09     INFO -  923 INFO TEST-PASS | browser/extensions/formautofill/test/browser/browser_creditCard_doorhanger.js | at least one notification displayed -
08:05:09     INFO -  924 INFO TEST-PASS | browser/extensions/formautofill/test/browser/browser_creditCard_doorhanger.js | 1 

:lchang do you have any update on this issue?
Flags: needinfo?(lukechang1209)
Whiteboard: [stockwell unknown] → [stockwell needswork]
This bug failed 41 times in the last 7 days, on Linux, OSX10, Windows 7, Windows 10 affecting opt, debug, pgo build types.
Link to a recent log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=165137248&lineNumber=29282 

:lchang do you have any update?
this is at risk to be disable-recommended at the current rate of failures and no response from triage owner or assignee in 1+ week.
Sorry for the late reply. As no one is working on Form Autofill at the moment, I would also recommend to disable it. Fortunately, the credit card feature is only available on the Nightly build so disabling it won't affect quality on the Beta and Release builds.
Flags: needinfo?(lukechang1209)
:jmaher, Taking in consideration Luke Chang's comment, should we disable this bug?
Flags: needinfo?(jmaher)
yes, let disable this on at least windows/osx, possibly everywhere this seems to fail often in all configs.

what is more scary is that I see references to this failing in mozilla-beta, but the feature doesn't exist there.
Flags: needinfo?(jmaher)
Attached patch Disable on Linux, OS.X and Win7 (obsolete) — — Splinter Review 
Added this patch to disable it on Linux, OS.X (debug) and only on Windows 7 because in the last 7 days there are only 7 failures on Windows 10
Attachment #8957833 - Flags: review?(jmaher)
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #20)
> what is more scary is that I see references to this failing in mozilla-beta,
> but the feature doesn't exist there.

Yeah, we enabled this feature in the testing environment only in order to ensure quality once we want to ship it to Beta.
Comment on attachment 8957833 [details] [diff] [review]
Disable on Linux, OS.X and Win7

Review of attachment 8957833 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/extensions/formautofill/test/browser/browser.ini
@@ +12,4 @@
>  [browser_autocomplete_marked_detached_tab.js]
>  [browser_check_installed.js]
>  [browser_creditCard_doorhanger.js]
> +skip-if = (os == "linux") || (os == "mac" && debug) || (os == "win" && os_version == '6.1') # bug 1425884 Disable due to frequent failures

we have a lot of window10 failurs as well, also both debug/opt/pgo, so lets do os == "win" and leave it there.

Basically this will only run on osx/opt.
Attachment #8957833 - Flags: review?(jmaher) → review-
Updated the patch, with (os == "win")
Attachment #8958025 - Flags: review?(jmaher)
Attachment #8957833 - Attachment is obsolete: true
Attachment #8958025 - Flags: review?(jmaher) → review+
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/393c5af3df3b
disabled browser_creditCard_doorhanger.js on Linux, Windows, OSX debug platforms r=jmaher
Keywords: checkin-needed
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Whiteboard: [stockwell disabled] → [stockwell disable-recommended]
Comment on attachment 8960854 [details] [diff] [review]
Added "=" after "skip-if"

Review of attachment 8960854 [details] [diff] [review]:
-----------------------------------------------------------------

good find.
Attachment #8960854 - Flags: review?(jmaher) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/94ff63119721
Syntax fix for the browser_creditCard_doorhanger.js test skipping. r=jmaher
Keywords: checkin-needed
status-firefox60: --- → affected
status-firefox61: --- → disabled
Whiteboard: [stockwell disable-recommended] → [stockwell disable-recommended][checking-needed-beta]
Whiteboard: [stockwell disable-recommended][checking-needed-beta] → [stockwell disabled][checkin-needed-beta]
https://hg.mozilla.org/releases/mozilla-beta/rev/dbb4439e8859
status-firefox60: affected → disabled
Whiteboard: [stockwell disabled][checkin-needed-beta] → [stockwell disabled]
Assignee: steveck324 → nobody
Priority: P5 → P2
Whiteboard: [stockwell disabled] → [stockwell disabled][ccautofill]
Duplicate of this bug: 1404453
Priority: P2 → P3
Whiteboard: [stockwell disabled][ccautofill] → [cc-autofill-mvp]
Whiteboard: [cc-autofill-mvp] → [cc-autofill-reserve]
Blocks: ccautofill-tests
Type: defect → enhancement
Keywords: leave-open
OS: Unspecified → All
Hardware: Unspecified → All
Version: unspecified → Trunk

Thanks to some work we've done on cc autofill, this test is now passing. I'm going to re-enable it.

Assignee: nobody → jmathies
Whiteboard: [cc-autofill-reserve] → [cc-autofill-mvp]
Status: NEW → ASSIGNED
Attachment #9164391 - Attachment is obsolete: true
Pushed by jmathies@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eb2f97b01576
Enable browser_creditCard_doorhanger.js. r=zbraniecki

https://hg.mozilla.org/mozilla-central/rev/eb2f97b01576

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.