Open
Bug 1425884
Opened 2 years ago
Updated 2 years ago
Intermittent browser/extensions/formautofill/test/browser/browser_creditCard_doorhanger.js | Uncaught exception - TypeError: form is null
Categories
(Toolkit :: Form Autofill, defect, P5)
Toolkit
Form Autofill
P5
Tracking
()
NEW
People
(Reporter: intermittent-bug-filer, Assigned: steveck)
References
Details
(Keywords: intermittent-failure, leave-open, Whiteboard: [stockwell disabled])
Attachments
(2 files, 1 obsolete file)
767 bytes,
patch
|
jmaher
:
review+
jmaher
:
checkin+
|
Details | Diff | Splinter Review |
904 bytes,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Filed by: csabou [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=152126298&repo=autoland https://queue.taskcluster.net/v1/task/PR2YUlRxTyu6NagF2wQZNw/runs/0/artifacts/public/logs/live_backing.log
Assignee | ||
Comment 1•2 years ago
|
||
Not sure how it could be reproduced cause autocomplete_creditcard_basic.html seems doesn't change recently. Let's see the reproduce rate in the following weeks.
Comment hidden (Intermittent Failures Robot) |
![]() |
||
Updated•2 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•2 years ago
|
Whiteboard: [stockwell needswork]
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•2 years ago
|
Assignee: nobody → schung
Flags: needinfo?(schung)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 12•2 years ago
|
||
This bug has failed 40 times in the last 7 days. It has failed on Linux, OS X, Windows 7 and Windows 10 affecting opt. debug and pgo build types. Failing tests: mochitest-browser-chrome-e10 Link to a recent log: https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=163631538&lineNumber=4426 Part of that log: 08:05:07 INFO - Buffered messages finished 08:05:07 ERROR - 916 INFO TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_creditCard_doorhanger.js | Uncaught exception - TypeError: form is null 08:05:07 INFO - 917 INFO Leaving test bound test_update_autofill_form_name 08:05:07 INFO - 918 INFO Entering test bound test_update_autofill_form_exp_date 08:05:07 INFO - 919 INFO expecting credit card saved 08:05:07 INFO - 920 INFO expecting record retrievals: creditCards 08:05:07 INFO - Not taking screenshot here: see the one that was previously logged 08:05:07 ERROR - 921 INFO TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_creditCard_doorhanger.js | 1 credit card in storage - Got 2, expected 1 08:05:07 INFO - Stack trace: 08:05:07 INFO - chrome://mochikit/content/browser-test.js:test_is:1271 08:05:07 INFO - chrome://mochitests/content/browser/browser/extensions/formautofill/test/browser/browser_creditCard_doorhanger.js:test_update_autofill_form_exp_date:523 08:05:08 INFO - 922 INFO expecting the target input being focused and indentified 08:05:09 INFO - 923 INFO TEST-PASS | browser/extensions/formautofill/test/browser/browser_creditCard_doorhanger.js | at least one notification displayed - 08:05:09 INFO - 924 INFO TEST-PASS | browser/extensions/formautofill/test/browser/browser_creditCard_doorhanger.js | 1 :lchang do you have any update on this issue?
Flags: needinfo?(lukechang1209)
Whiteboard: [stockwell unknown] → [stockwell needswork]
Comment hidden (Intermittent Failures Robot) |
Comment 14•2 years ago
|
||
This bug failed 41 times in the last 7 days, on Linux, OSX10, Windows 7, Windows 10 affecting opt, debug, pgo build types. Link to a recent log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=165137248&lineNumber=29282 :lchang do you have any update?
Comment 15•2 years ago
|
||
this is at risk to be disable-recommended at the current rate of failures and no response from triage owner or assignee in 1+ week.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 18•2 years ago
|
||
Sorry for the late reply. As no one is working on Form Autofill at the moment, I would also recommend to disable it. Fortunately, the credit card feature is only available on the Nightly build so disabling it won't affect quality on the Beta and Release builds.
Flags: needinfo?(lukechang1209)
Comment 19•2 years ago
|
||
:jmaher, Taking in consideration Luke Chang's comment, should we disable this bug?
Flags: needinfo?(jmaher)
Comment 20•2 years ago
|
||
yes, let disable this on at least windows/osx, possibly everywhere this seems to fail often in all configs. what is more scary is that I see references to this failing in mozilla-beta, but the feature doesn't exist there.
Flags: needinfo?(jmaher)
Comment 21•2 years ago
|
||
Added this patch to disable it on Linux, OS.X (debug) and only on Windows 7 because in the last 7 days there are only 7 failures on Windows 10
Attachment #8957833 -
Flags: review?(jmaher)
Comment 22•2 years ago
|
||
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #20) > what is more scary is that I see references to this failing in mozilla-beta, > but the feature doesn't exist there. Yeah, we enabled this feature in the testing environment only in order to ensure quality once we want to ship it to Beta.
Comment 23•2 years ago
|
||
Comment on attachment 8957833 [details] [diff] [review] Disable on Linux, OS.X and Win7 Review of attachment 8957833 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/extensions/formautofill/test/browser/browser.ini @@ +12,4 @@ > [browser_autocomplete_marked_detached_tab.js] > [browser_check_installed.js] > [browser_creditCard_doorhanger.js] > +skip-if = (os == "linux") || (os == "mac" && debug) || (os == "win" && os_version == '6.1') # bug 1425884 Disable due to frequent failures we have a lot of window10 failurs as well, also both debug/opt/pgo, so lets do os == "win" and leave it there. Basically this will only run on osx/opt.
Attachment #8957833 -
Flags: review?(jmaher) → review-
Comment hidden (Intermittent Failures Robot) |
Comment 25•2 years ago
|
||
Updated the patch, with (os == "win")
Attachment #8958025 -
Flags: review?(jmaher)
Updated•2 years ago
|
Attachment #8957833 -
Attachment is obsolete: true
Updated•2 years ago
|
Attachment #8958025 -
Flags: review?(jmaher) → review+
Updated•2 years ago
|
Keywords: checkin-needed,
leave-open
Comment 26•2 years ago
|
||
Pushed by btara@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/393c5af3df3b disabled browser_creditCard_doorhanger.js on Linux, Windows, OSX debug platforms r=jmaher
Keywords: checkin-needed
Comment 27•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/393c5af3df3b
Updated•2 years ago
|
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 32•2 years ago
|
||
Attachment #8960854 -
Flags: review?(jmaher)
Updated•2 years ago
|
Whiteboard: [stockwell disabled] → [stockwell disable-recommended]
Comment 33•2 years ago
|
||
Comment on attachment 8960854 [details] [diff] [review] Added "=" after "skip-if" Review of attachment 8960854 [details] [diff] [review]: ----------------------------------------------------------------- good find.
Attachment #8960854 -
Flags: review?(jmaher) → review+
Updated•2 years ago
|
Attachment #8958025 -
Flags: checkin+
Updated•2 years ago
|
Keywords: checkin-needed
Comment 34•2 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/94ff63119721 Syntax fix for the browser_creditCard_doorhanger.js test skipping. r=jmaher
Keywords: checkin-needed
Comment 35•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/94ff63119721
Updated•2 years ago
|
status-firefox60:
--- → affected
status-firefox61:
--- → disabled
Whiteboard: [stockwell disable-recommended] → [stockwell disable-recommended][checking-needed-beta]
![]() |
||
Updated•2 years ago
|
Whiteboard: [stockwell disable-recommended][checking-needed-beta] → [stockwell disabled][checkin-needed-beta]
Comment 36•2 years ago
|
||
uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/dbb4439e8859
Whiteboard: [stockwell disabled][checkin-needed-beta] → [stockwell disabled]
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•