Closed Bug 1425906 Opened 2 years ago Closed 2 years ago

Windows linkers interpret LINK specially, so we can't `export LINK`

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

References

Details

Attachments

(1 file)

link.exe interprets getenv("LINK") as a set of options to prepend to its command line: https://msdn.microsoft.com/en-us/library/6y6t9esh.aspx

And lld-link mimics this behavior: https://github.com/llvm-mirror/lld/blob/master/COFF/DriverUtils.cpp#L753

So bad things happen if we try to `export LINK=...` on Windows. We'll need some other way to tell the build system to use lld.
Assignee: nobody → dmajor
Attachment #8937761 - Flags: review?(mh+mozilla)
Attachment #8937761 - Flags: review?(mh+mozilla) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9cfe039a796
Rename LINK to LINKER throughout the build system. r=glandium
https://hg.mozilla.org/mozilla-central/rev/e9cfe039a796
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.