1426012 - Assertion failure: on, at /home/worker/workspace/build/src/media/mtransport/nr_timer.cpp:172

Status: RESOLVED WORKSFORME

(Core :: WebRTC, defect, P3)

Description

[Jason Kratzer [:jkratzer]]

Found while fuzzing esr52 rev 2a12e40bacfa.  Currently, none of the identified test cases reproduce.

rax = 0x0000000000625d50   rdx = 0x0000000000000000
rcx = 0x00007f953a8a52cc   rbx = 0x00007ffe6db17748
rsi = 0x00007f9535a7e770   rdi = 0x00007f9535a7d540
rbp = 0x00007ffe6db17760   rsp = 0x00007ffe6db17740
r8 = 0x00007f9535a7e770    r9 = 0x00007f953d047c00
r10 = 0x0000000000000012   r11 = 0x0000000000000000
r12 = 0x00007ffe6db17740   r13 = 0x00000000000001f3
r14 = 0x00007ffe6db17a18   r15 = 0x00007f95393b802a
rip = 0x00007f9537a59a35
OS|Linux|0.0.0 Linux 4.4.0-1041-aws #50-Ubuntu SMP Wed Nov 15 22:18:17 UTC 2017 x86_64
CPU|amd64|family 6 model 63 stepping 2|8
GPU|||
Crash|SIGSEGV|0x0|0
0|0|libxul.so|CheckSTSThread|hg:hg.mozilla.org/releases/mozilla-esr52:media/mtransport/nr_timer.cpp:2a12e40bacfa|172|0x0
0|1|libxul.so|NR_async_timer_set|hg:hg.mozilla.org/releases/mozilla-esr52:media/mtransport/nr_timer.cpp:2a12e40bacfa|225|0x5
0|2|libxul.so|nr_ice_peer_ctx_destroy|hg:hg.mozilla.org/releases/mozilla-esr52:media/mtransport/third_party/nICEr/src/ice/ice_peer_ctx.c:2a12e40bacfa|499|0x1b
0|3|libxul.so|mozilla::NrIceCtx::~NrIceCtx|hg:hg.mozilla.org/releases/mozilla-esr52:media/mtransport/nricectx.cpp:2a12e40bacfa|687|0xc
0|4|libxul.so|mozilla::NrIceCtx::~NrIceCtx|hg:hg.mozilla.org/releases/mozilla-esr52:media/mtransport/nricectx.cpp:2a12e40bacfa|691|0x5
0|5|libxul.so|mozilla::NrIceCtx::Release|hg:hg.mozilla.org/releases/mozilla-esr52:media/mtransport/nricectx.h:2a12e40bacfa|334|0xe
0|6|libxul.so|mozilla::PeerConnectionImpl::SetupIceRestart|hg:hg.mozilla.org/releases/mozilla-esr52:media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:2a12e40bacfa|1701|0x8
0|7|libxul.so|mozilla::PeerConnectionImpl::CreateOffer|hg:hg.mozilla.org/releases/mozilla-esr52:media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:2a12e40bacfa|1588|0x8
0|8|libxul.so|mozilla::PeerConnectionImpl::CreateOffer|hg:hg.mozilla.org/releases/mozilla-esr52:media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:2a12e40bacfa|1528|0xb
0|9|libxul.so|mozilla::dom::PeerConnectionImplBinding::createOffer|hg:hg.mozilla.org/releases/mozilla-esr52:media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.h:2a12e40bacfa|371|0xf
0|10|libxul.so|mozilla::dom::GenericBindingMethod|hg:hg.mozilla.org/releases/mozilla-esr52:dom/bindings/BindingUtils.cpp:2a12e40bacfa|2904|0x9
0|11|libxul.so|js::CallJSNative|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/jscntxtinlines.h:2a12e40bacfa|239|0x9
0|12|libxul.so|js::InternalCallOrConstruct|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|459|0xf
0|13|libxul.so|Interpret|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|510|0xf
0|14|libxul.so|js::RunScript|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|405|0xb
0|15|libxul.so|js::InternalCallOrConstruct|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|477|0xb
0|16|libxul.so|js::Call|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|523|0x5
0|17|libxul.so|js::PromiseObject::create|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/builtin/Promise.cpp:2a12e40bacfa|1345|0x19
0|18|libxul.so|PromiseConstructor|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/builtin/Promise.cpp:2a12e40bacfa|1275|0x5
0|19|libxul.so|js::CallJSNativeConstructor|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/jscntxtinlines.h:2a12e40bacfa|239|0x9
0|20|libxul.so|InternalConstruct|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|550|0xf
0|21|libxul.so|js::Construct|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|601|0x5
0|22|libxul.so|JS::Construct|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/jsapi.cpp:2a12e40bacfa|2854|0x20
0|23|libxul.so|xpc::JSXrayTraits::construct|hg:hg.mozilla.org/releases/mozilla-esr52:js/xpconnect/wrappers/XrayWrapper.cpp:2a12e40bacfa|939|0x13
0|24|libxul.so|js::Proxy::construct|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/proxy/Proxy.cpp:2a12e40bacfa|419|0x15
0|25|libxul.so|js::proxy_Construct|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/proxy/Proxy.cpp:2a12e40bacfa|698|0x8
0|26|libxul.so|js::CallJSNativeConstructor|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/jscntxtinlines.h:2a12e40bacfa|239|0x9
0|27|libxul.so|InternalConstruct|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|562|0xe
0|28|libxul.so|Interpret|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|2914|0xf
0|29|libxul.so|js::RunScript|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|405|0xb
0|30|libxul.so|js::InternalCallOrConstruct|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|477|0xb
0|31|libxul.so|js::Call|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|523|0x5
0|32|libxul.so|PromiseReactionJob|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/builtin/Promise.cpp:2a12e40bacfa|934|0x10
0|33|libxul.so|js::CallJSNative|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/jscntxtinlines.h:2a12e40bacfa|239|0x9
0|34|libxul.so|js::InternalCallOrConstruct|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|459|0xf
0|35|libxul.so|js::Call|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|523|0x5
0|36|libxul.so|JS::Call|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/jsapi.cpp:2a12e40bacfa|2828|0x20
0|37|libxul.so|mozilla::dom::PromiseJobCallback::Call|hg:hg.mozilla.org/releases/mozilla-esr52:obj-firefox/dom/bindings/PromiseBinding.cpp:2a12e40bacfa|64|0x20
0|38|libxul.so|mozilla::dom::PromiseJobCallback::Call|hg:hg.mozilla.org/releases/mozilla-esr52:obj-firefox/dist/include/mozilla/dom/PromiseBinding.h:2a12e40bacfa|176|0x12
0|39|libxul.so|PromiseJobRunnable::Run|hg:hg.mozilla.org/releases/mozilla-esr52:obj-firefox/dist/include/mozilla/dom/PromiseBinding.h:2a12e40bacfa|191|0x17
0|40|libxul.so|mozilla::dom::Promise::PerformMicroTaskCheckpoint|hg:hg.mozilla.org/releases/mozilla-esr52:dom/promise/Promise.cpp:2a12e40bacfa|1055|0x6
0|41|libxul.so|XPCJSContext::BeforeProcessTask|hg:hg.mozilla.org/releases/mozilla-esr52:js/xpconnect/src/XPCJSContext.cpp:2a12e40bacfa|3572|0x5
0|42|libxul.so|nsThread::ProcessNextEvent|hg:hg.mozilla.org/releases/mozilla-esr52:xpcom/threads/nsThread.cpp:2a12e40bacfa|1184|0xc
0|43|libxul.so|NS_ProcessNextEvent|hg:hg.mozilla.org/releases/mozilla-esr52:xpcom/glue/nsThreadUtils.cpp:2a12e40bacfa|361|0xd
0|44|libxul.so|mozilla::dom::XMLHttpRequestMainThread::SendInternal|hg:hg.mozilla.org/releases/mozilla-esr52:dom/xhr/XMLHttpRequestMainThread.cpp:2a12e40bacfa|2956|0x11
0|45|libxul.so|mozilla::dom::XMLHttpRequestMainThread::Send|hg:hg.mozilla.org/releases/mozilla-esr52:dom/xhr/XMLHttpRequestMainThread.h:2a12e40bacfa|333|0x5
0|46|libxul.so|mozilla::dom::XMLHttpRequestBinding::send|hg:hg.mozilla.org/releases/mozilla-esr52:obj-firefox/dom/bindings/XMLHttpRequestBinding.cpp:2a12e40bacfa|650|0x16
0|47|libxul.so|mozilla::dom::GenericBindingMethod|hg:hg.mozilla.org/releases/mozilla-esr52:dom/bindings/BindingUtils.cpp:2a12e40bacfa|2904|0x9
0|48|libxul.so|js::CallJSNative|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/jscntxtinlines.h:2a12e40bacfa|239|0x9
0|49|libxul.so|js::InternalCallOrConstruct|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|459|0xf
0|50|libxul.so|Interpret|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|510|0xf
0|51|libxul.so|js::RunScript|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|405|0xb
0|52|libxul.so|js::ExecuteKernel|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|686|0x5
0|53|libxul.so|EvalKernel|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/builtin/Eval.cpp:2a12e40bacfa|328|0x1a
0|54|libxul.so|js::IndirectEval|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/builtin/Eval.cpp:2a12e40bacfa|421|0xa
0|55|||||0x149a245c4a75
0|56|||||0x7f9515bd7b28
0|57|||||0x149a24463e1d
0|58|libxul.so|EnterBaseline|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/jit/BaselineJIT.cpp:2a12e40bacfa|155|0x9
0|59|libxul.so|js::jit::EnterBaselineMethod|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/jit/BaselineJIT.cpp:2a12e40bacfa|193|0xb
0|60|libxul.so|js::RunScript|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|395|0xb
0|61|libxul.so|js::InternalCallOrConstruct|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|477|0xb
0|62|libxul.so|js::jit::DoCallFallback|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/jit/BaselineIC.cpp:2a12e40bacfa|6020|0x13
0|63|||||0x149a24465111
0|64|||||0x7f950a7ce050
0|65|||||0x149a24463e1d
0|66|libxul.so|EnterBaseline|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/jit/BaselineJIT.cpp:2a12e40bacfa|155|0x9
0|67|libxul.so|js::jit::EnterBaselineAtBranch|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/jit/BaselineJIT.cpp:2a12e40bacfa|261|0xb
0|68|libxul.so|Interpret|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|1916|0x14
0|69|libxul.so|js::RunScript|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|405|0xb
0|70|libxul.so|js::ExecuteKernel|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|686|0x5
0|71|libxul.so|js::Execute|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/vm/Interpreter.cpp:2a12e40bacfa|719|0x28
0|72|libxul.so|Evaluate|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/jsapi.cpp:2a12e40bacfa|4440|0xf
0|73|libxul.so|Evaluate|hg:hg.mozilla.org/releases/mozilla-esr52:js/src/jsapi.cpp:2a12e40bacfa|4466|0x1d
0|74|libxul.so|nsJSUtils::EvaluateString|hg:hg.mozilla.org/releases/mozilla-esr52:dom/base/nsJSUtils.cpp:2a12e40bacfa|207|0x1c
0|75|libxul.so|nsJSUtils::EvaluateString|hg:hg.mozilla.org/releases/mozilla-esr52:dom/base/nsJSUtils.cpp:2a12e40bacfa|275|0x2a
0|76|libxul.so|nsScriptLoader::EvaluateScript|hg:hg.mozilla.org/releases/mozilla-esr52:dom/base/nsScriptLoader.cpp:2a12e40bacfa|2194|0x21
0|77|libxul.so|nsScriptLoader::ProcessRequest|hg:hg.mozilla.org/releases/mozilla-esr52:dom/base/nsScriptLoader.cpp:2a12e40bacfa|1979|0xb
0|78|libxul.so|nsScriptLoader::ProcessScriptElement|hg:hg.mozilla.org/releases/mozilla-esr52:dom/base/nsScriptLoader.cpp:2a12e40bacfa|1712|0xf
0|79|libxul.so|nsScriptElement::MaybeProcessScript|hg:hg.mozilla.org/releases/mozilla-esr52:dom/base/nsScriptElement.cpp:2a12e40bacfa|149|0x13
0|80|libxul.so|nsIScriptElement::AttemptToExecute|hg:hg.mozilla.org/releases/mozilla-esr52:dom/base/nsIScriptElement.h:2a12e40bacfa|222|0x3
0|81|libxul.so|nsHtml5TreeOpExecutor::RunScript|hg:hg.mozilla.org/releases/mozilla-esr52:parser/html/nsHtml5TreeOpExecutor.cpp:2a12e40bacfa|666|0x10
0|82|libxul.so|nsHtml5TreeOpExecutor::RunFlushLoop|hg:hg.mozilla.org/releases/mozilla-esr52:parser/html/nsHtml5TreeOpExecutor.cpp:2a12e40bacfa|489|0x8
0|83|libxul.so|nsHtml5ExecutorReflusher::Run|hg:hg.mozilla.org/releases/mozilla-esr52:parser/html/nsHtml5TreeOpExecutor.cpp:2a12e40bacfa|58|0xd
0|84|libxul.so|nsThread::ProcessNextEvent|hg:hg.mozilla.org/releases/mozilla-esr52:xpcom/threads/nsThread.cpp:2a12e40bacfa|1216|0x11
0|85|libxul.so|NS_ProcessNextEvent|hg:hg.mozilla.org/releases/mozilla-esr52:xpcom/glue/nsThreadUtils.cpp:2a12e40bacfa|361|0xd
0|86|libxul.so|mozilla::ipc::MessagePump::Run|hg:hg.mozilla.org/releases/mozilla-esr52:ipc/glue/MessagePump.cpp:2a12e40bacfa|96|0xa
0|87|libxul.so|MessageLoop::RunInternal|hg:hg.mozilla.org/releases/mozilla-esr52:ipc/chromium/src/base/message_loop.cc:2a12e40bacfa|232|0x17
0|88|libxul.so|MessageLoop::Run|hg:hg.mozilla.org/releases/mozilla-esr52:ipc/chromium/src/base/message_loop.cc:2a12e40bacfa|225|0x8
0|89|libxul.so|nsBaseAppShell::Run|hg:hg.mozilla.org/releases/mozilla-esr52:widget/nsBaseAppShell.cpp:2a12e40bacfa|156|0xd
0|90|libxul.so|XRE_RunAppShell|hg:hg.mozilla.org/releases/mozilla-esr52:toolkit/xre/nsEmbedFunctions.cpp:2a12e40bacfa|866|0x6
0|91|libxul.so|mozilla::ipc::MessagePumpForChildProcess::Run|hg:hg.mozilla.org/releases/mozilla-esr52:ipc/glue/MessagePump.cpp:2a12e40bacfa|269|0x5
0|92|libxul.so|MessageLoop::RunInternal|hg:hg.mozilla.org/releases/mozilla-esr52:ipc/chromium/src/base/message_loop.cc:2a12e40bacfa|232|0x17
0|93|libxul.so|MessageLoop::Run|hg:hg.mozilla.org/releases/mozilla-esr52:ipc/chromium/src/base/message_loop.cc:2a12e40bacfa|225|0x8
0|94|libxul.so|XRE_InitChildProcess|hg:hg.mozilla.org/releases/mozilla-esr52:toolkit/xre/nsEmbedFunctions.cpp:2a12e40bacfa|698|0xf
0|95|plugin-container|content_process_main|hg:hg.mozilla.org/releases/mozilla-esr52:ipc/contentproc/plugin-container.cpp:2a12e40bacfa|197|0xe
0|96|libc-2.23.so||||0x20830
0|97|plugin-container|MOZ_ReportAssertionFailure|hg:hg.mozilla.org/releases/mozilla-esr52:mfbt/Assertions.h:2a12e40bacfa|170|0x5

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Byron, would you mind taking an initial look?

Comment 2

[Byron Campen [:bwc]]

(In reply to Nico Grunbaum [:ng] from comment #1)
> Byron, would you mind taking an initial look?

I won't be able to look until tomorrow at the earliest, maybe not before the break.

Comment 3

[Daniel Bodea [:danibodea]]

Byron, any updates here?
Jason, is there a working test case for this?

Thanks!

Comment 4

[Byron Campen [:bwc]]

So we've reworked the ICE restart code, and made sure that we only run this teardown code on STS, so this bug should be fixed.

Comment 5

[Jason Kratzer [:jkratzer]]

Just to add, a working testcase had come up several months ago but that testcase does not reproduce using esr60 nor mc-debug.

Comment 6

[Daniel Bodea [:danibodea]]

Considering the 2 comments above, I will mark this issue as Resolved Worksforme.

Thanks!