1426082 - Marionette unit test test_transport.py is not run

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I just noticed that the unit test module test_transport.py is not part of the unit-test manifest, and as such isn't get run at all.

https://searchfox.org/mozilla-central/source/testing/marionette/harness/marionette_harness/tests/unit/test_transport.py

https://searchfox.org/mozilla-central/source/testing/marionette/harness/marionette_harness/tests/unit/unit-tests.ini

Some of the tests like for Proto2Command and Proto2Response are not valid anymore since my patch on bug 1409030 got landed. But given that the tests were not run, no-one noticed that.

Comment 1

[David Burns :automatedtester]

[Mass Change 2018-01-15] Moving bugs to backlog

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1426082 - Remove superfluous transport tests.

This drops the tests for Marionette protocol level 2.  Protocol levels
below 2 were removed some time ago:

	https://bugzilla.mozilla.org/show_bug.cgi?id=1409030

Review commit: https://reviewboard.mozilla.org/r/223286/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223286/

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1426082 - Enable test_transport.py.

Review commit: https://reviewboard.mozilla.org/r/223288/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223288/

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8954141 [details]
Bug 1426082 - Remove superfluous transport tests.

https://reviewboard.mozilla.org/r/223286/#review229468

Ups, looks like I missed to remove those on the other bug given that this test module is not getting run. Thanks!

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8954142 [details]
Bug 1426082 - Enable test_transport.py.

https://reviewboard.mozilla.org/r/223288/#review229470

::: testing/marionette/harness/marionette_harness/tests/unit/unit-tests.ini:31
(Diff revision 1)
>  [test_element_state_chrome.py]
>  skip-if = appname == 'fennec'
>  [test_text.py]
>  
>  [test_typing.py]
> +[test_transport.py]

Lets put this close to test_marionette at the top of the file because it tests the basics, and we don't have an alphabetical order anyway.

Comment 6

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8954141 [details]
Bug 1426082 - Remove superfluous transport tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/223286/diff/1-2/

Comment 7

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8954142 [details]
Bug 1426082 - Enable test_transport.py.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/223288/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f57a1cd84e0c
Remove superfluous transport tests. r=whimboo
https://hg.mozilla.org/integration/autoland/rev/bc82a797a301
Enable test_transport.py. r=whimboo

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f57a1cd84e0c
https://hg.mozilla.org/mozilla-central/rev/bc82a797a301