Closed Bug 1426082 Opened 2 years ago Closed 2 years ago

Marionette unit test test_transport.py is not run

Categories

(Testing :: Marionette, defect, P3)

Version 3
defect

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: whimboo, Assigned: ato)

References

Details

Attachments

(2 files)

I just noticed that the unit test module test_transport.py is not part of the unit-test manifest, and as such isn't get run at all.

https://searchfox.org/mozilla-central/source/testing/marionette/harness/marionette_harness/tests/unit/test_transport.py

https://searchfox.org/mozilla-central/source/testing/marionette/harness/marionette_harness/tests/unit/unit-tests.ini

Some of the tests like for Proto2Command and Proto2Response are not valid anymore since my patch on bug 1409030 got landed. But given that the tests were not run, no-one noticed that.
[Mass Change 2018-01-15] Moving bugs to backlog
Priority: -- → P3
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment on attachment 8954141 [details]
Bug 1426082 - Remove superfluous transport tests.

https://reviewboard.mozilla.org/r/223286/#review229468

Ups, looks like I missed to remove those on the other bug given that this test module is not getting run. Thanks!
Attachment #8954141 - Flags: review?(hskupin) → review+
Comment on attachment 8954142 [details]
Bug 1426082 - Enable test_transport.py.

https://reviewboard.mozilla.org/r/223288/#review229470

::: testing/marionette/harness/marionette_harness/tests/unit/unit-tests.ini:31
(Diff revision 1)
>  [test_element_state_chrome.py]
>  skip-if = appname == 'fennec'
>  [test_text.py]
>  
>  [test_typing.py]
> +[test_transport.py]

Lets put this close to test_marionette at the top of the file because it tests the basics, and we don't have an alphabetical order anyway.
Attachment #8954142 - Flags: review?(hskupin) → review+
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f57a1cd84e0c
Remove superfluous transport tests. r=whimboo
https://hg.mozilla.org/integration/autoland/rev/bc82a797a301
Enable test_transport.py. r=whimboo
https://hg.mozilla.org/mozilla-central/rev/f57a1cd84e0c
https://hg.mozilla.org/mozilla-central/rev/bc82a797a301
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.