Closed Bug 1426094 Opened 4 years ago Closed 4 years ago
Non-cropped URLs are not rendered
59 bytes, text/x-review-board-request
Load https://api.github.com/ The urls are not displayed. You can click the property names to crop the urls and then it works. Regressed by bug 1419479, https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e96a38ecdd8611b39e39bc9fec2bb9ae171a80de&tochange=7b67bdbb812e67dce18dda2e19f2f204db6e9676 Most probably it's https://github.com/devtools-html/devtools-core/commit/e9238260b69412731d3f158444be5a10eb8f2658
This was fixed in GitHub, but now we need to update the reps library in m-c for this to be fixed there too. This needs to be done in the 59 cycle, and is documented here: https://github.com/devtools-html/devtools-core/blob/master/packages/devtools-reps/RELEASE.md
Which gives us until mid-January to update reps in m-c, although we shouldn't wait that long because this isn't the only fix that will come with reps, so we should let the new reps release sit in nightly for a while.
Oriol, can you check that now the bug is gone with the new reps bundle ? Thanks !
Note that the patch isn't on Nightly yet, only on mozilla-central
Yes, now it's fixed on Nightly. Let's add a test.
There is a test for this case on Github, but yes, I think we can create a mochitest for the json viewer.
Comment on attachment 8938648 [details] Bug 1426094 - Add test for URL linkification in the JSON Viewer https://reviewboard.mozilla.org/r/209244/#review215386 Thanks for the patch, looks good to me. R+ assuming my inline comment is resolved. Honza ::: devtools/client/jsonview/test/browser_jsonview_url_linkification.js:6 (Diff revision 1) > +/* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */ > +/* vim: set ts=2 et sw=2 tw=80: */ > +/* Any copyright is dedicated to the Public Domain. > + * http://creativecommons.org/publicdomain/zero/1.0/ */ > + > +"use strict"; nit: please append an empty line after "use strict";
Attachment #8938648 - Flags: review?(odvarko) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/0059514e73b5 Add test for URL linkification in the JSON Viewer r=Honza
I have reproduced this bug with Nightly 59.0a1 (2017-12-19)on Windows 10 , 64 Bit ! This bug's fix is Verified with latest Beta ! Build ID 20180215111455 User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
QA Whiteboard: [testday-20180216]
I have reproduced this bug with Nightly 59.0a1 (2017-12-19) on Ubuntu 16.04 This bug's fix is now verified with latest Beta 59.0b10 Build ID 20180215111455 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0 [testday-20180216]
Marking as verified per comment 13 and comment 14.
I tested the fix on beta 59.0b10 using macOS 10.13, too. The bug is not reproducing anymore. I verified the fix on latest Nightly 60.0a1 on macOS 10.13, Windows 10 x64 and Ubuntu 16.04.
You need to log in before you can comment on or make changes to this bug.