Closed
Bug 1426094
Opened 7 years ago
Closed 7 years ago
Non-cropped URLs are not rendered
Categories
(DevTools :: JSON Viewer, defect)
DevTools
JSON Viewer
Tracking
(firefox-esr52 unaffected, firefox57 unaffected, firefox58 unaffected, firefox59 verified, firefox60 verified)
VERIFIED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox57 | --- | unaffected |
firefox58 | --- | unaffected |
firefox59 | --- | verified |
firefox60 | --- | verified |
People
(Reporter: Oriol, Assigned: Oriol)
References
Details
(Keywords: regression)
Attachments
(1 file)
Load https://api.github.com/
The urls are not displayed.
You can click the property names to crop the urls and then it works.
Regressed by bug 1419479, https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e96a38ecdd8611b39e39bc9fec2bb9ae171a80de&tochange=7b67bdbb812e67dce18dda2e19f2f204db6e9676
Most probably it's https://github.com/devtools-html/devtools-core/commit/e9238260b69412731d3f158444be5a10eb8f2658
Flags: needinfo?(nchevobbe)
Assignee | ||
Comment 1•7 years ago
|
||
Flags: needinfo?(nchevobbe)
Comment 2•7 years ago
|
||
This was fixed in GitHub, but now we need to update the reps library in m-c for this to be fixed there too.
This needs to be done in the 59 cycle, and is documented here: https://github.com/devtools-html/devtools-core/blob/master/packages/devtools-reps/RELEASE.md
Comment 3•7 years ago
|
||
Which gives us until mid-January to update reps in m-c, although we shouldn't wait that long because this isn't the only fix that will come with reps, so we should let the new reps release sit in nightly for a while.
Comment 4•7 years ago
|
||
Oriol, can you check that now the bug is gone with the new reps bundle ?
Thanks !
Flags: needinfo?(oriol-bugzilla)
Comment 5•7 years ago
|
||
Note that the patch isn't on Nightly yet, only on mozilla-central
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•7 years ago
|
||
Yes, now it's fixed on Nightly. Let's add a test.
Flags: needinfo?(oriol-bugzilla)
Comment 8•7 years ago
|
||
There is a test for this case on Github, but yes, I think we can create a mochitest for the json viewer.
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8938648 [details]
Bug 1426094 - Add test for URL linkification in the JSON Viewer
https://reviewboard.mozilla.org/r/209244/#review215386
Thanks for the patch, looks good to me.
R+ assuming my inline comment is resolved.
Honza
::: devtools/client/jsonview/test/browser_jsonview_url_linkification.js:6
(Diff revision 1)
> +/* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */
> +/* vim: set ts=2 et sw=2 tw=80: */
> +/* Any copyright is dedicated to the Public Domain.
> + * http://creativecommons.org/publicdomain/zero/1.0/ */
> +
> +"use strict";
nit: please append an empty line after "use strict";
Attachment #8938648 -
Flags: review?(odvarko) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Updated•7 years ago
|
Assignee: nobody → oriol-bugzilla
status-firefox57:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Comment 11•7 years ago
|
||
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0059514e73b5
Add test for URL linkification in the JSON Viewer r=Honza
Keywords: checkin-needed
Comment 12•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Comment 13•7 years ago
|
||
I have reproduced this bug with Nightly 59.0a1 (2017-12-19)on Windows 10 , 64 Bit !
This bug's fix is Verified with latest Beta !
Build ID 20180215111455
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
QA Whiteboard: [testday-20180216]
Comment 14•7 years ago
|
||
I have reproduced this bug with Nightly 59.0a1 (2017-12-19) on Ubuntu 16.04
This bug's fix is now verified with latest Beta 59.0b10
Build ID 20180215111455
User Agent Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
[testday-20180216]
Assignee | ||
Comment 15•7 years ago
|
||
Marking as verified per comment 13 and comment 14.
Status: RESOLVED → VERIFIED
Comment 16•7 years ago
|
||
I tested the fix on beta 59.0b10 using macOS 10.13, too. The bug is not reproducing anymore.
I verified the fix on latest Nightly 60.0a1 on macOS 10.13, Windows 10 x64 and Ubuntu 16.04.
status-firefox60:
--- → verified
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•