Non-cropped URLs are not rendered

VERIFIED FIXED in Firefox 59

Status

defect
VERIFIED FIXED
a year ago
10 months ago

People

(Reporter: Oriol, Assigned: Oriol)

Tracking

({regression})

unspecified
Firefox 59
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox57 unaffected, firefox58 unaffected, firefox59 verified, firefox60 verified)

Details

Attachments

(1 attachment)

(Assignee)

Comment 1

a year ago
Filed https://github.com/devtools-html/devtools-core/issues/864
Flags: needinfo?(nchevobbe)
This was fixed in GitHub, but now we need to update the reps library in m-c for this to be fixed there too.
This needs to be done in the 59 cycle, and is documented here: https://github.com/devtools-html/devtools-core/blob/master/packages/devtools-reps/RELEASE.md
Which gives us until mid-January to update reps in m-c, although we shouldn't wait that long because this isn't the only fix that will come with reps, so we should let the new reps release sit in nightly for a while.
Oriol, can you check that now the bug is gone with the new reps bundle ?
Thanks !
Flags: needinfo?(oriol-bugzilla)
Note that the patch isn't on Nightly yet, only on mozilla-central
Comment hidden (mozreview-request)
(Assignee)

Comment 7

a year ago
Yes, now it's fixed on Nightly. Let's add a test.
Flags: needinfo?(oriol-bugzilla)
There is a test for this case on Github, but yes, I think we can create a mochitest for the json viewer.
Comment on attachment 8938648 [details]
Bug 1426094 - Add test for URL linkification in the JSON Viewer

https://reviewboard.mozilla.org/r/209244/#review215386

Thanks for the patch, looks good to me.

R+ assuming my inline comment is resolved.

Honza

::: devtools/client/jsonview/test/browser_jsonview_url_linkification.js:6
(Diff revision 1)
> +/* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */
> +/* vim: set ts=2 et sw=2 tw=80: */
> +/* Any copyright is dedicated to the Public Domain.
> + * http://creativecommons.org/publicdomain/zero/1.0/ */
> +
> +"use strict";

nit: please append an empty line after "use strict";
Attachment #8938648 - Flags: review?(odvarko) → review+
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Keywords: checkin-needed
Assignee: nobody → oriol-bugzilla

Comment 11

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0059514e73b5
Add test for URL linkification in the JSON Viewer r=Honza
Keywords: checkin-needed

Comment 12

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0059514e73b5
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
I have reproduced this bug with Nightly 59.0a1 (2017-12-19)on Windows 10 , 64 Bit ! 

This bug's fix is Verified with latest Beta !

Build   ID    20180215111455
User Agent    Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
QA Whiteboard: [testday-20180216]

Comment 14

a year ago
I have reproduced this bug with Nightly 59.0a1 (2017-12-19) on Ubuntu 16.04

This bug's fix is now verified with latest Beta 59.0b10

Build ID      20180215111455
User Agent    Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0

[testday-20180216]
(Assignee)

Comment 15

a year ago
Marking as verified per comment 13 and comment 14.
Status: RESOLVED → VERIFIED
I tested the fix on beta 59.0b10 using macOS 10.13, too. The bug is not reproducing anymore. 
I verified the fix on latest Nightly 60.0a1 on macOS 10.13, Windows 10 x64 and Ubuntu 16.04.

Updated

10 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.