Closed Bug 1426094 Opened 5 years ago Closed 5 years ago

Non-cropped URLs are not rendered


(DevTools :: JSON Viewer, defect)

Not set


(firefox-esr52 unaffected, firefox57 unaffected, firefox58 unaffected, firefox59 verified, firefox60 verified)

Firefox 59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 --- verified
firefox60 --- verified


(Reporter: Oriol, Assigned: Oriol)



(Keywords: regression)


(1 file)

Flags: needinfo?(nchevobbe)
Depends on: 1426108
This was fixed in GitHub, but now we need to update the reps library in m-c for this to be fixed there too.
This needs to be done in the 59 cycle, and is documented here:
Which gives us until mid-January to update reps in m-c, although we shouldn't wait that long because this isn't the only fix that will come with reps, so we should let the new reps release sit in nightly for a while.
Oriol, can you check that now the bug is gone with the new reps bundle ?
Thanks !
Flags: needinfo?(oriol-bugzilla)
Note that the patch isn't on Nightly yet, only on mozilla-central
Yes, now it's fixed on Nightly. Let's add a test.
Flags: needinfo?(oriol-bugzilla)
There is a test for this case on Github, but yes, I think we can create a mochitest for the json viewer.
Comment on attachment 8938648 [details]
Bug 1426094 - Add test for URL linkification in the JSON Viewer

Thanks for the patch, looks good to me.

R+ assuming my inline comment is resolved.


::: devtools/client/jsonview/test/browser_jsonview_url_linkification.js:6
(Diff revision 1)
> +/* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */
> +/* vim: set ts=2 et sw=2 tw=80: */
> +/* Any copyright is dedicated to the Public Domain.
> + * */
> +
> +"use strict";

nit: please append an empty line after "use strict";
Attachment #8938648 - Flags: review?(odvarko) → review+
Keywords: checkin-needed
Assignee: nobody → oriol-bugzilla
Pushed by
Add test for URL linkification in the JSON Viewer r=Honza
Keywords: checkin-needed
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
I have reproduced this bug with Nightly 59.0a1 (2017-12-19)on Windows 10 , 64 Bit ! 

This bug's fix is Verified with latest Beta !

Build   ID    20180215111455
User Agent    Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
QA Whiteboard: [testday-20180216]
I have reproduced this bug with Nightly 59.0a1 (2017-12-19) on Ubuntu 16.04

This bug's fix is now verified with latest Beta 59.0b10

Build ID      20180215111455
User Agent    Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0

Marking as verified per comment 13 and comment 14.
I tested the fix on beta 59.0b10 using macOS 10.13, too. The bug is not reproducing anymore. 
I verified the fix on latest Nightly 60.0a1 on macOS 10.13, Windows 10 x64 and Ubuntu 16.04.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.