Closed Bug 1426105 Opened 8 years ago Closed 8 years ago

mozregression-gui swaps the tochange and fromchange hashes and ends up with no builds after switching branches during a find fix run

Categories

(Testing :: mozregression, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Kwan, Assigned: Kwan)

Details

Attachments

(1 file)

49 bytes, text/x-github-pull-request
Details | Review
Version: 0.9.17 Using mozregression version: 2.3.21 This was doing a find _fix_ run, initial range choice was dates 2017-08-04 to 2017-06-12 07-09 b 07-22 b 07-29 g 07-26 g 07-24 b 07-25 b Bisect on m-c [e8400551 - 07484bfd] 9eddb0a9 b 4f821dab g 2017-12-19T12:45:43: INFO : Narrowed inbound regression window from [9eddb0a9, e8400551] (3 builds) to [9eddb0a9, 4f821dab] (2 builds) (~1 steps left) 2017-12-19T12:45:43: DEBUG : Starting merge handling... 2017-12-19T12:45:43: DEBUG : Using url: https://hg.mozilla.org/mozilla-central/json-pushes?changeset=4f821dab4306fd0aff947ce55a1304acd7e4cf95&full=1 2017-12-19T12:45:44: DEBUG : Found commit message: Backed out changeset 674770e65a4f (bug 1265472) for memory leaks in browser_webauthn_telemetry.js 2017-12-19T12:45:44: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=4f821dab4306fd0aff947ce55a1304acd7e4cf95&full=1 2017-12-19T12:45:44: DEBUG : Using url: https://hg.mozilla.org/integration/mozilla-inbound/json-pushes?changeset=4f821dab4306fd0aff947ce55a1304acd7e4cf95&full=1 2017-12-19T12:45:44: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=67be9d4a6c2cb1f344cf6faa62702bf020ee940e 2017-12-19T12:45:45: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?fromchange=67be9d4a6c2cb1f344cf6faa62702bf020ee940e&tochange=4f821dab4306fd0aff947ce55a1304acd7e4cf95 2017-12-19T12:45:45: INFO : ************* Switching to autoland by process of elimination (no branch detected in commit message) 2017-12-19T12:45:45: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=4f821dab4306fd0aff947ce55a1304acd7e4cf95 2017-12-19T12:45:45: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?fromchange=4f821dab4306fd0aff947ce55a1304acd7e4cf95&tochange=67be9d4a6c2cb1f344cf6faa62702bf020ee940e 2017-12-19T12:46:04: INFO : Stopped Note the URL before the "Switch...by process of elimination": https://hg.mozilla.org/integration/autoland/json-pushes?fromchange=67be9d4a6c2cb1f344cf6faa62702bf020ee940e&tochange=4f821dab4306fd0aff947ce55a1304acd7e4cf95 and the URL after: https://hg.mozilla.org/integration/autoland/json-pushes?fromchange=4f821dab4306fd0aff947ce55a1304acd7e4cf95&tochange=67be9d4a6c2cb1f344cf6faa62702bf020ee940e same hashes, other way round. First has builds, second is blank. If I repeat the same bisection as a find bug run, and tag good builds as bad etc. to find the same thing, it doesn't swap and keeps going.
I believe I have located the problem and have a fix. This only happens when there is no branch name in the m-c changeset, as is the case with 4f821dab4306fd0aff947ce55a1304acd7e4cf95 Normally when finding a branch the code ends up here: https://github.com/mozilla/mozregression/blob/e7478859e047f2cf670352b37036cb7beb531c5e/mozregression/bisector.py#L317 where the function self._reverse_if_find_fix() is called. But in the case of no named branch where it does the "process of elimination" it ends up here: https://github.com/mozilla/mozregression/blob/e7478859e047f2cf670352b37036cb7beb531c5e/mozregression/bisector.py#L284 where that function isn't called. Inserting a call there to self._reverse_if_find_fix() fixes this bug, so I'll submit a PR. As a side note I ran into https://bitbucket.org/anthony_tuininga/cx_freeze/issues/32/cant-compile-cx_freeze-in-ubuntu-1304 and had to change the dependency to cx_Freeze = 5.0 to get pip install -r requirements-gui-dev.txt to succeed.
Attached file GitHub PR
Assignee: nobody → moz-ian
Tested with gui-0.9.19 and can confirmed fixed. Thanks wlach!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: