Closed Bug 1426191 Opened 2 years ago Closed 2 years ago

Turn on gpu mochitests on windows10-64-qr

Categories

(Core :: Graphics: WebRender, enhancement, P1)

Other Branch
x86_64
Windows 10
enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: kats, Assigned: kats)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted][triage])

Attachments

(3 files)

The testing try push I did at https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd1120edb402ea7688119baf18e6f7decfbca550 shows that there's only one failure in the gpu mochitests on windows10 with WR enabled, and that's just because the test in question doesn't account for webrender. This should be easily fixable and then we can turn on this test suite.
Try push looks green, and I fixed the linting error in my local patchset.

:catlee, I'm planning on enabling a bunch of windows10-64-qr jobs, which we'll need to test webrender on windows. Flagging you for review on these patches so that you can approve the extra automation load it's going to add. Note that all of these webrender-enabled jobs will need to run on virtual-with-gpu virtualization, because without the GPU webrender won't run, so please that into account when considering load/cost.

In this bug I'm enabling mochitest-gpu which takes (per push) 6 minutes on debug and 4 minutes on debug, so that's 10 minutes of virtual-with-gpu machine untilization per push. Less with SETA. I assume that won't be a problem.
Comment on attachment 8937820 [details]
Bug 1426191 - Update test_acceleration to check for webrender windows.

https://reviewboard.mozilla.org/r/208510/#review214324

::: dom/base/nsDOMWindowUtils.cpp:2344
(Diff revision 1)
>  
>  NS_IMETHODIMP
> +nsDOMWindowUtils::GetIsWebRenderRequested(bool* retval)
> +{
> +  *retval = gfxPlatform::WebRenderPrefEnabled()
> +         || gfxPlatform::WebRenderEnvvarEnabled();

nit: || on previous line
Attachment #8937820 - Flags: review?(dvander) → review+
Comment on attachment 8937821 [details]
Bug 1426191 - Adjust regexes to match QuantumRender builds.

https://reviewboard.mozilla.org/r/208512/#review214344
Attachment #8937821 - Flags: review?(dustin) → review+
Comment on attachment 8937822 [details]
Bug 1426191 - Turn on gpu mochitests for windows10-64 QuantumRender builds.

https://reviewboard.mozilla.org/r/208514/#review214346
Attachment #8937822 - Flags: review?(dustin) → review+
^ rebased and addressed dvander's comment
I'm not sure if catlee will get around to looking at this before the break, and I'd prefer to land this before then. Given the small amount of machine time involved for this suite I'm going to go ahead and land it, and leave the review flag so we can discuss it whenever catlee is back.
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3ac75a8a4e8c
Update test_acceleration to check for webrender windows. r=dvander
https://hg.mozilla.org/integration/autoland/rev/cb60de4bfc7a
Adjust regexes to match QuantumRender builds. r=dustin
https://hg.mozilla.org/integration/autoland/rev/38b2f6c02ea7
Turn on gpu mochitests for windows10-64 QuantumRender builds. r=dustin
Comment on attachment 8937822 [details]
Bug 1426191 - Turn on gpu mochitests for windows10-64 QuantumRender builds.

https://reviewboard.mozilla.org/r/208514/#review214936
Attachment #8937822 - Flags: review?(catlee) → review+
You need to log in before you can comment on or make changes to this bug.