Closed
Bug 1426191
Opened 6 years ago
Closed 6 years ago
Turn on gpu mochitests on windows10-64-qr
Categories
(Core :: Graphics: WebRender, enhancement, P1)
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: [gfx-noted][triage])
Attachments
(3 files)
The testing try push I did at https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd1120edb402ea7688119baf18e6f7decfbca550 shows that there's only one failure in the gpu mochitests on windows10 with WR enabled, and that's just because the test in question doesn't account for webrender. This should be easily fixable and then we can turn on this test suite.
Assignee | ||
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8396478ab01dae4af150790aa46fc61d9dd10a2
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•6 years ago
|
||
Try push looks green, and I fixed the linting error in my local patchset. :catlee, I'm planning on enabling a bunch of windows10-64-qr jobs, which we'll need to test webrender on windows. Flagging you for review on these patches so that you can approve the extra automation load it's going to add. Note that all of these webrender-enabled jobs will need to run on virtual-with-gpu virtualization, because without the GPU webrender won't run, so please that into account when considering load/cost. In this bug I'm enabling mochitest-gpu which takes (per push) 6 minutes on debug and 4 minutes on debug, so that's 10 minutes of virtual-with-gpu machine untilization per push. Less with SETA. I assume that won't be a problem.
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8937820 [details] Bug 1426191 - Update test_acceleration to check for webrender windows. https://reviewboard.mozilla.org/r/208510/#review214324 ::: dom/base/nsDOMWindowUtils.cpp:2344 (Diff revision 1) > > NS_IMETHODIMP > +nsDOMWindowUtils::GetIsWebRenderRequested(bool* retval) > +{ > + *retval = gfxPlatform::WebRenderPrefEnabled() > + || gfxPlatform::WebRenderEnvvarEnabled(); nit: || on previous line
Attachment #8937820 -
Flags: review?(dvander) → review+
Comment 7•6 years ago
|
||
mozreview-review |
Comment on attachment 8937821 [details] Bug 1426191 - Adjust regexes to match QuantumRender builds. https://reviewboard.mozilla.org/r/208512/#review214344
Attachment #8937821 -
Flags: review?(dustin) → review+
Comment 8•6 years ago
|
||
mozreview-review |
Comment on attachment 8937822 [details] Bug 1426191 - Turn on gpu mochitests for windows10-64 QuantumRender builds. https://reviewboard.mozilla.org/r/208514/#review214346
Attachment #8937822 -
Flags: review?(dustin) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 12•6 years ago
|
||
^ rebased and addressed dvander's comment
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 16•6 years ago
|
||
I'm not sure if catlee will get around to looking at this before the break, and I'd prefer to land this before then. Given the small amount of machine time involved for this suite I'm going to go ahead and land it, and leave the review flag so we can discuss it whenever catlee is back.
Comment 17•6 years ago
|
||
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3ac75a8a4e8c Update test_acceleration to check for webrender windows. r=dvander https://hg.mozilla.org/integration/autoland/rev/cb60de4bfc7a Adjust regexes to match QuantumRender builds. r=dustin https://hg.mozilla.org/integration/autoland/rev/38b2f6c02ea7 Turn on gpu mochitests for windows10-64 QuantumRender builds. r=dustin
Updated•6 years ago
|
Blocks: stage-wr-trains
Priority: P3 → P1
Comment 18•6 years ago
|
||
mozreview-review |
Comment on attachment 8937822 [details] Bug 1426191 - Turn on gpu mochitests for windows10-64 QuantumRender builds. https://reviewboard.mozilla.org/r/208514/#review214936
Attachment #8937822 -
Flags: review?(catlee) → review+
Comment 19•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3ac75a8a4e8c https://hg.mozilla.org/mozilla-central/rev/cb60de4bfc7a https://hg.mozilla.org/mozilla-central/rev/38b2f6c02ea7
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•