Closed
Bug 1426205
Opened 7 years ago
Closed 7 years ago
ES module usage in exported tests cause eslint errors
Categories
(Firefox :: New Tab Page, defect, P1)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: Mardak, Assigned: Mardak)
References
Details
Attachments
(1 file)
ES modules from bug 1424352 is causing eslint errors on pine:
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/browser/extensions/activity-stream/test/functional/mochitest/browser_as_load_location.js:1:1 | Definition for rule 'import/no-commonjs' was not found (import/no-commonjs) [log…]
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/browser/extensions/activity-stream/test/schemas/pings.js:1:1 | Parsing error: 'import' and 'export' may appear only with 'sourceType: module' (eslint) [log…]
|
Assignee | |
Comment 1•7 years ago
|
||
Maybe just updating eslintignore?
via irc Standard8:
can m-c just ignore those?
if it is linted at source, then I don’t mind too much
maybe not as ideal
Assignee: nobody → edilee
Iteration: --- → 1.25
Priority: -- → P1
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8937771 [details]
Bug 1426205 - ES module usage in exported tests cause eslint errors.
https://reviewboard.mozilla.org/r/208478/#review214564
Attachment #8937771 -
Flags: review?(khudson) → review+
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f53e45ada433
ES module usage in exported tests cause eslint errors. r=k88hudson
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
|
||
Updated•6 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•