1426289 - 58's ANGLE doesn't flush vertexAttrib4f updates

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[Kelsey Gilbert [:jgilbert]]

The linked URL should show three points. (From left to right: red, blue, green)
Right now, it shows just the red point. If you disable DEPTH_TEST, the point won't move, but will look blue.

This is because it's actually the final blue point, but the vertexAttrib4f data hasn't been sent to D3D, so it renders in the same place. With DEPTH_TEST, rendering points in the same place as the first one fails the depth test, so we are left with just the original point.

This appears to be fixed upstream:
https://chromium.googlesource.com/angle/angle/+/9088557fe47e0ce1487b248b60acbc740acd7801

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Add MozFramebuffer.

Review commit: https://reviewboard.mozilla.org/r/208586/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208586/

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Move the webgl backbuffer into webgl.

Review commit: https://reviewboard.mozilla.org/r/208588/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208588/

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1426289 - Add test for vertexAttrib4f updates.

ANGLE cherry-pick: 9088557fe47e0ce1487b248b60acbc740acd7801

    D3D11: Fix dirty current value updates.

    Fixes a bug where subsequent updates to a "current value" (disabled)
    Vertex Attribute would not trigger the state change to D3D11 such that
    the updated buffer handle would be applied to D3D11. Also adds a test
    to cover the problem case.

    This bug was introduced in 2bc947334cad:
    "D3D11: Minor optimizations to vertex attribute application."

    BUG=chromium:779675
    BUG=angleproject:1155

Review commit: https://reviewboard.mozilla.org/r/208590/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208590/

Comment 4

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8937897 [details]
Bug 1426289 - Add test for vertexAttrib4f updates.

https://reviewboard.mozilla.org/r/208590/#review214374

r+ for cherry-pick from upstream

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb576536eafb
Cherry-pick angle issue 1155. - r=lenzak
https://hg.mozilla.org/integration/mozilla-inbound/rev/b22b826e89dc
Add test for vertexAttrib4f updates.

Comment 6

[Kelsey Gilbert [:jgilbert]]

(FYI Milan)

Comment 7

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8937897 [details]
Bug 1426289 - Add test for vertexAttrib4f updates.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/208590/diff/1-2/

Comment 8

[Kelsey Gilbert [:jgilbert]]

Man, mozreview is not having a good time here.

Comment 9

[Kelsey Gilbert [:jgilbert]]

Attachment: 0001-Bug-1426289-Cherry-pick-angle-issue-1155.-r-lenzak.patch

Let's add these manually.

Comment 10

[Kelsey Gilbert [:jgilbert]]

Attachment: 0002-Bug-1426289-Add-test-for-vertexAttrib4f-updates.patch

Comment 11

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/fb576536eafb
https://hg.mozilla.org/mozilla-central/rev/b22b826e89dc

Comment 12

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8937938 [details] [diff] [review]
0001-Bug-1426289-Cherry-pick-angle-issue-1155.-r-lenzak.patch

Approval Request Comment
[Feature/Bug causing the regression]: FF58 ANGLE update
[User impact if declined]: Broken rendering for mostly example content.
[Is this code covered by automated tests?]: test included
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: low risk
[Why is the change risky/not risky?]: This is a cherry-pick of the upstream ANGLE fix, so it fixes this problem. The changed code increases invalidation, so it should be safe.
[String changes made/needed]: none

Comment 13

[Gerry Chang [:gchang]]

Comment on attachment 8937938 [details] [diff] [review]
0001-Bug-1426289-Cherry-pick-angle-issue-1155.-r-lenzak.patch

Cherry pick ANGLE fix in 58. Beta58+.

Comment 14

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a9eef6584951
https://hg.mozilla.org/releases/mozilla-beta/rev/f681d554e292