1426372 - Tab crash when opening some pages that contain column-span

Status: VERIFIED FIXED

(Core :: Layout, defect, P2)

Description

[roxleitan]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20171207013525

[Affected versions]:
Nightly 59.0a1 try build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=078cb3dc6e8523df4a04386b0f20d2b070058c36

[Affected platforms]:
Mac OS X 10.12, Ubuntu 16.04 x64

[Steps to reproduce]:
1.Launch Firefox with a new profile
2.Set layout.css.column-span.enabled on True
3.Restart FF
4.Go to https://jsfiddle.net/5oo2gzLy/9/
5.Scroll down using the mouse wheel

[Expected result]:
The page should be scrolled down without issues

[Actual result]:
Tab crashed

Browser Console messages:

TypeError: this.sink is null[Learn More]  network-monitor.js:527:5
Dave is ready.  jsbin-4.1.1.min.js:28
NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIHttpChannel.contentCharset]  network-monitor.js:594
TypeError: this.sink is null[Learn More]  network-monitor.js:527:5
To edit settings, type this string into the console: o1kv9pm95p1g  jsbin-4.1.1.min.js:3
d[ o_0 ]b  runner-4.1.1.min.js:1
GET 
https://media2.giphy.com/ 
[HTTP/2.0 403 Forbidden 42ms]
Column span found!TypeError: can't access dead object[Learn More]

[Note]:
The issue is not reproducible with "layout.css.column-span.enabled" set on False

Comment 1

[Neerja Pancholi[:neerja]]

I fixed this by updating the patches for Bug 1421105 which is why there are no patches attached here. Marking this as fixed.
This can be tested using the build at:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a00281108ce40dca22fcc9f10b988826c73d3d42&selectedJob=154461955

Comment 2

[roxleitan]

Verified fixed using the build from https://treeherder.mozilla.org/#/jobs?repo=try&revision=a00281108ce40dca22fcc9f10b988826c73d3d42&selectedJob=154461955 on Ubuntu 16.04 x64 and Mac OS X 10.12.