1426384 - [Wayland] - Update window decoration setup for Wayland Gtk+ backend

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P2)

Description

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

When we use Wayland backend we need to slightly update our nsWindow setup to correctly configure window decoration.

Comment 1

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1426384 - call gdk_window_set_decorations() on mShell GdkWindow only,

To have any effect we need to call gdk_window_set_decorations() on top-level GdkWindow only.
When rendering to mContainer the mGdkWindow belongs to mContainer so we need to get the window
from mShell explicitly.

Review commit: https://reviewboard.mozilla.org/r/208732/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208732/

Comment 2

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1426384 - Don't use CSD_SUPPORT_FULL on Wayland unless it's overriden by MOZ_GTK_TITLEBAR_DECORATION,

Wayland compositors do not support GDK_DECOR_BORDER so use CSD decorations exclusively.

Review commit: https://reviewboard.mozilla.org/r/208734/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208734/

Comment 3

[Jan Horak [:jhorak]]

Comment on attachment 8937998 [details]
Bug 1426384 - call gdk_window_set_decorations() on mShell GdkWindow only,

https://reviewboard.mozilla.org/r/208732/#review214798

Comment 4

[Jan Horak [:jhorak]]

Comment on attachment 8937999 [details]
Bug 1426384 - Don't use CSD_SUPPORT_FULL on Wayland unless it's overriden by MOZ_GTK_TITLEBAR_DECORATION,

https://reviewboard.mozilla.org/r/208734/#review214800

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8a340376091
call gdk_window_set_decorations() on mShell GdkWindow only, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/c0f87918768e
Don't use CSD_SUPPORT_FULL on Wayland unless it's overriden by MOZ_GTK_TITLEBAR_DECORATION, r=jhorak

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b8a340376091
https://hg.mozilla.org/mozilla-central/rev/c0f87918768e