1426426 - Stop shipping communicator.css

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement, P3)

Description

[:Gijs (out for now; he/him)]

Apparently this is referenced from the xslt-qa stuff, which I'm hoping to remove in bug 1425356, and dom/xslt/tests/XSLTMark/XSLTMark.xul and layout-debug. Pretty sure we can just remove it and/or only ship it with those (test-only) bits if we need to keep it for some reason. Probably worth checking with layout folks.

Comment 1

[:Gijs (out for now; he/him)]

(When removing it, we should remove the whitelist entry in browser/base/content/test/static/browser_all_files_referenced.js )

Comment 2

[Issei Horie [:is2ei]]

Hi I'm Issei.
Could I work on this issue?

Comment 3

[:Gijs (out for now; he/him)]

(In reply to Issei Horie [:is2ei] from comment #2)
> Hi I'm Issei.
> Could I work on this issue?

Sure, do you need more help than what's in comment #0? Feel free to ask.

Comment 4

[Issei Horie [:is2ei]]

Attachment: bug-1426426.patch

Thanks Gijs!

I have questions.
- How can we test the change?
- Do we need to remove https://searchfox.org/mozilla-central/source/browser/themes/linux/communicator/jar.mn#7 too?

I created a patch. Could you check it, please?

Comment 5

[:Gijs (out for now; he/him)]

Comment on attachment 8984903 [details] [diff] [review]
bug-1426426.patch

Review of attachment 8984903 [details] [diff] [review]:
-----------------------------------------------------------------

Hi, yes, you will need to remove the entirety of the `communicator` directory in the 3 os subdirectories (linux, osx, windows) of browser/themes/ . You will also need to remove the 

DIRS += ["communicator"]

lines from all the moz.build files in those browser/themes subdirectories.

Thank you for working on this!

::: dom/xslt/tests/XSLTMark/XSLTMark.xul
@@ -3,4 @@
>     - License, v. 2.0. If a copy of the MPL was not distributed with this
>     - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
>  
> -<?xml-stylesheet href="chrome://communicator/skin/" type="text/css"?>

This should probably just be replaced with "chrome://global/skin/" as the href.

Comment 6

[Issei Horie [:is2ei]]

Attachment: bug-1426426.patch

Thanks for your comment! I updated the patch.
Could you check it, please?

Comment 7

[:Gijs (out for now; he/him)]

Comment on attachment 8985810 [details] [diff] [review]
bug-1426426.patch

Review of attachment 8985810 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d03f4a4af28
Stop shipping communicator.css. r=gijs

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/1d03f4a4af28